*: Prevent Leader from accidentally hanging up data inconsistency #597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhl003
force-pushed
the
graceful_failover
branch
5 times, most recently
from
c14eb2a to
abf7e92
Compare
2. Add leaderstop cmd in xenon conf 3. Adjust project structure
zhl003
force-pushed
the
graceful_failover
branch
from
abf7e92 to
645e893
Compare
acekingke
reviewed
Jul 15, 2022
| }, | ||
| } | ||
|
|
||
| assert.Equal(t, lifeCycle, xenonCase.Lifecycle) |
There was a problem hiding this comment.
use "github.com/onsi/gomega" lib， Expect
|
|
||
| "github.com/bitly/go-simplejson" | ||
| _ "github.com/go-sql-driver/mysql" | ||
| "github.com/jmoiron/sqlx" |
There was a problem hiding this comment.
_ "github.com/go-sql-driver/mysql" is ok， Do not use "github.com/jmoiron/sqlx"
acekingke
reviewed
Jul 15, 2022
| cfg := loadConfiguration() | ||
| dsn := mysqlUser + ":" + cfg.password + "@tcp(" + mysqlHost + ")/" | ||
| server := MySQLServer{DSN: dsn} | ||
| Conn, err := server.GetNewDBConn() |
There was a problem hiding this comment.
conn must close when finished
| if err != nil { | ||
| log.Error(err) | ||
| } | ||
| IsLeader := IsLeader(Conn) |
There was a problem hiding this comment.
when error, to here is will crash.
| } | ||
| // Step 1: disable event scheduler | ||
| log.Info("Disabling event scheduler") | ||
| stmt, err := SetEventScheduler(Conn, false) |
| if err != nil { | ||
| log.Error(err) | ||
| } | ||
| log.Infof("set readonly to true: %s", stmt) |
There was a problem hiding this comment.
the same, when error , it will crash.
| if err != nil { | ||
| log.Error(err) | ||
| } | ||
| log.Infof("%d,long running writes: %s", num, stmt) |
There was a problem hiding this comment.
the same, when error , it will crash.
| leaderSet = gtid.ExecutedGTIDSet | ||
| } | ||
| } | ||
| db, err := server.GetNewDBConn() |
| if err != nil { | ||
| log.Fatal(err) | ||
| } | ||
| contents, err2 := ioutil.ReadAll(xenonConfFile) |
There was a problem hiding this comment.
defer xenonConfFile.Close() should at here.
| return false, fmt.Errorf("db connection failed after %s timeout", timeout) | ||
| case <-ticker.C: | ||
| _, err := sqlx.Connect("mysql", server.DSN) | ||
| if err == nil { |
There was a problem hiding this comment.
when success， need close.
| @@ -8,4 +8,4 @@ spec: | |||
| # hostname if empty, use the leader as hostname | |||
| hostName: sample-mysql-0 | |||
| clusterName: sample | |||
| # nfsServerAddress: "" | |||
| # nfsServerAddress: "" | |||
| @@ -37,4 +37,4 @@ EXPOSE 8801 | |||
| VOLUME ["/var/lib/xenon", "/etc/xenon"] | |||
|
|
|||
| ENTRYPOINT ["xenon"] | |||
| CMD ["-c", "/etc/xenon/xenon.json"] | |||
| CMD ["-c", "/etc/xenon/xenon.json"] | |||
acekingke
reviewed
Jul 15, 2022
| for { | ||
| select { | ||
| case <-timeoutExceeded: | ||
| return false, fmt.Errorf("db connection failed after %s timeout", timeout) |
There was a problem hiding this comment.
timeout is int64, use %s is very dangerous.
| select { | ||
| case <-timeoutExceeded: | ||
| return false, fmt.Errorf("db connection failed after %s timeout", timeout) | ||
| case <-ticker.C: |
There was a problem hiding this comment.
need times to retry. 1 second is two frequent.
zhl003
pushed a commit
to zhl003/radondb-mysql-kubernetes
that referenced
this pull request
Aug 17, 2022
*: Prevent Leader from accidentally hanging up data inconsistency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/enhancement
Which issue(s) this PR fixes?
Fixes #598
What this PR does?
Summary:
Special notes for your reviewer?