Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: Add inCluster related API and xenon checker #596

Merged
merged 2 commits into from
Jul 13, 2022
Merged

*: Add inCluster related API and xenon checker #596

merged 2 commits into from
Jul 13, 2022

Conversation

runkecheng
Copy link
Collaborator

What type of PR is this?

/enhancement

Which issue(s) this PR fixes?

Fixes #

What this PR does?

Summary:

  • Add the dockerfile of xenon.
  • Add inCluster related API and xenon checker

TODO: Moving other dockerfiles to the Build directory, this requires
updating related CIs first.

        new file:   build/xenon/Dockerfile
        new file:   cmd/staticcheck.conf
        new file:   cmd/xenon/main.go
        modified:   mysqlcluster/container/xenon.go
        modified:   sidecar/config.go
        new file:   utils/incluster.go

Special notes for your reviewer?

@runkecheng
feat(build): init bulid folder
75a0b9b 
add the dockerfile of xenon.

TODO: Moving other dockerfiles to the Build directory, this requires
updating related CIs first.
@runkecheng runkecheng added the enhancement New feature or request label Jul 12, 2022
@runkecheng runkecheng added this to the v2.3.0 milestone Jul 12, 2022
@runkecheng runkecheng requested review from acekingke and zhl003 July 12, 2022 03:46
@runkecheng runkecheng force-pushed the feat_xenon_checker branch 2 times, most recently from e25793d to 4b06b91 Compare July 12, 2022 06:09
@runkecheng runkecheng force-pushed the feat_xenon_checker branch from 4b06b91 to ce3ab21 Compare July 12, 2022 06:19
zhl003
zhl003 approved these changes Jul 13, 2022
View reviewed changes
Copy link
Collaborator

@zhl003 zhl003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@runkecheng runkecheng merged commit 0c496e3 into radondb:main Jul 13, 2022
zhl003 pushed a commit to zhl003/radondb-mysql-kubernetes that referenced this pull request Aug 17, 2022
@runkecheng
*: Add inCluster related API and xenon checker (radondb#596)
2ea05b9 
* feat(build): init bulid folder

add the dockerfile of xenon.

TODO: Moving other dockerfiles to the Build directory, this requires
updating related CIs first.

* feat(container): Added inCluster related API and xenon checker
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhl003 zhl003 zhl003 approved these changes

@acekingke acekingke Awaiting requested review from acekingke

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v2.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@runkecheng @zhl003