Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

controller: delete cluster then delete backup cr #570 #581

Merged
merged 1 commit into from
Jul 14, 2022

Conversation

acekingke
Copy link
Contributor

What type of PR is this?

/bug

Which issue(s) this PR fixes?

Fixes #570

What this PR does?

Summary:

  1. add a finalizer
  2. before delete cluster cr, delete the backup cr.

Special notes for your reviewer?

@acekingke acekingke added the bug Something isn't working label Jul 5, 2022
@acekingke acekingke added this to the Next milestone Jul 5, 2022
@acekingke acekingke self-assigned this Jul 5, 2022
Copy link
Collaborator

@zhl003 zhl003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems no problem ,but only thing is if user want to delete a specified backup when
cluster is alive ,finalizer will prevent it ?

Copy link
Collaborator

@zhl003 zhl003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@acekingke acekingke merged commit 4ea1492 into radondb:main Jul 14, 2022
zhl003 pushed a commit to zhl003/radondb-mysql-kubernetes that referenced this pull request Aug 17, 2022
controller: delete cluster then delete backup cr radondb#570
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug]The cluster is deleted, but the automatic backup job is not deleted
3 participants