Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

syncer: Support update the mysql plugin configuration. #526

Merged
merged 2 commits into from
Jun 15, 2022

Conversation

runkecheng
Copy link
Collaborator

What type of PR is this?

/enhancement

Which issue(s) this PR fixes?

Fixes #523

What this PR does?

Summary:

  1. Remove the duplicate configuration parameters in mysql cm.
  2. Support update the mysql plugin configuration.

Special notes for your reviewer?

@runkecheng runkecheng added bug Something isn't working enhancement New feature or request labels Jun 14, 2022
@runkecheng runkecheng added this to the v2.2.0 milestone Jun 14, 2022
@runkecheng runkecheng requested review from acekingke and zhl003 June 14, 2022 08:54
@runkecheng runkecheng self-assigned this Jun 14, 2022
@runkecheng runkecheng changed the title Fix plugin paras syncer: Support update the mysql plugin configuration. Jun 14, 2022
Copy link
Contributor

@acekingke acekingke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@zhl003 zhl003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@runkecheng runkecheng merged commit a6d61c4 into radondb:main Jun 15, 2022
zhl003 pushed a commit to zhl003/radondb-mysql-kubernetes that referenced this pull request Aug 17, 2022
* feat(cluster): Support update the mysql plugin configuration.

fix: radondb#523

* fix(cluster): Remove the duplicate configuration parameters in mysql cm.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] The parameters in plugin.cnf cannot be customized
3 participants