Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: Support tls for external #492 #518

Merged
merged 1 commit into from
Jun 15, 2022

Conversation

zhl003
Copy link
Collaborator

@zhl003 zhl003 commented Jun 8, 2022

What type of PR is this?

Which issue(s) this PR fixes?

Fixes #492

What this PR does?

Summary:
Support tls for external

Special notes for your reviewer?

@zhl003 zhl003 self-assigned this Jun 8, 2022
@zhl003 zhl003 added the enhancement New feature or request label Jun 8, 2022
@zhl003 zhl003 force-pushed the support_TLS_for_external branch from 1d3df22 to 8b76fb8 Compare June 8, 2022 10:33
sidecar/init.go Outdated Show resolved Hide resolved
sidecar/init.go Show resolved Hide resolved
utils/constants.go Outdated Show resolved Hide resolved
mysqlcluster/mysqlcluster.go Outdated Show resolved Hide resolved
sidecar/init.go Outdated Show resolved Hide resolved
sidecar/init.go Show resolved Hide resolved
@zhl003 zhl003 requested a review from acekingke June 13, 2022 03:17
@zhl003 zhl003 force-pushed the support_TLS_for_external branch from 7a413ad to df3ede5 Compare June 14, 2022 09:42
@runkecheng
Copy link
Collaborator

Before the first word of all comments, there must be a space. If the first word is not a variable name or function name, the first letter should be capitalized.

var test string

//test    ×
// test     √

// if test xxx    ×
// If test xxx    √

1 similar comment
@runkecheng
Copy link
Collaborator

Before the first word of all comments, there must be a space. If the first word is not a variable name or function name, the first letter should be capitalized.

var test string

//test    ×
// test     √

// if test xxx    ×
// If test xxx    √

@zhl003 zhl003 force-pushed the support_TLS_for_external branch from df3ede5 to 2072be5 Compare June 15, 2022 06:38
sidecar/init.go Outdated Show resolved Hide resolved
@zhl003 zhl003 force-pushed the support_TLS_for_external branch 3 times, most recently from 5a20fd8 to ad81e7d Compare June 15, 2022 07:01
1. Add a new CR variables tlsSecretName to support TLS.
2. Add there new auto configed mysql variables to support TLS.
3. Add Doc how to use tls
@zhl003 zhl003 force-pushed the support_TLS_for_external branch from ad81e7d to 1fb28b8 Compare June 15, 2022 07:13
@runkecheng runkecheng merged commit 57b6b5e into radondb:main Jun 15, 2022
@zhl003 zhl003 added this to the v2.2.0 milestone Jun 15, 2022
zhl003 added a commit to zhl003/radondb-mysql-kubernetes that referenced this pull request Aug 17, 2022
1. Add a new CR variables tlsSecretName to support TLS.
2. Add there new auto configed mysql variables to support TLS.
3. Add Doc how to use tls
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Transport Layer Security (TLS) cryptographic protocol
3 participants