Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chart: Environment variable name spelling error #514

Merged
merged 1 commit into from
Jun 14, 2022

Conversation

runkecheng
Copy link
Collaborator

@runkecheng runkecheng commented Jun 8, 2022

What type of PR is this?

/bug

Which issue(s) this PR fixes?

Fixes #

What this PR does?

Summary:

ENABLED_WEBHOOKS -> ENABLE_WEBHOOKS

Special notes for your reviewer?

@runkecheng runkecheng added bug Something isn't working chart labels Jun 8, 2022
@runkecheng runkecheng self-assigned this Jun 8, 2022
Copy link
Collaborator

@zhl003 zhl003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@runkecheng runkecheng force-pushed the fix_env_webhook branch 2 times, most recently from e66949a to f645027 Compare June 8, 2022 10:26
@runkecheng runkecheng added this to the v2.2.0 milestone Jun 10, 2022
Copy link
Contributor

@acekingke acekingke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

- - name: ENABLED_WEBHOOKS
+ - name: ENABLE_WEBHOOKS
@runkecheng runkecheng merged commit 2f4dc45 into radondb:main Jun 14, 2022
Copy link
Collaborator

@zhl003 zhl003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

zhl003 pushed a commit to zhl003/radondb-mysql-kubernetes that referenced this pull request Aug 17, 2022
- - name: ENABLED_WEBHOOKS
+ - name: ENABLE_WEBHOOKS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working chart
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants