Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mysqlcluster: innodb_log_file_size auto config. #501 #510

Merged
merged 1 commit into from
Jun 15, 2022

Conversation

acekingke
Copy link
Contributor

What type of PR is this?

/enhancement

Which issue(s) this PR fixes?

Fixes #501

What this PR does?

Summary:

  1. When the redo log file size is not set manually, auto set redo log file size is 25% of innodb_buffer_pool_size , but never over 8G.
  2. when users want set over 8G, they should set it in yaml file manually.

Special notes for your reviewer?

@acekingke acekingke added the enhancement New feature or request label Jun 2, 2022
@acekingke acekingke added this to the Next milestone Jun 2, 2022
@acekingke acekingke requested review from andyli029 and runkecheng June 2, 2022 02:34
@acekingke acekingke self-assigned this Jun 2, 2022
@acekingke acekingke marked this pull request as draft June 2, 2022 02:34
@runkecheng
Copy link
Collaborator

add unit test?

@acekingke acekingke requested a review from zhl003 June 2, 2022 06:53
@zhl003 zhl003 marked this pull request as ready for review June 2, 2022 07:53
Copy link
Collaborator

@zhl003 zhl003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can refer to the following https://dev.mysql.com/doc/refman/8.0/en/innodb-dedicated-server.html

Perhaps we can set these size flowing below:

  • innodb_log_file_size

    As of MySQL 8.0.14, log file size is configured according to the automatically configured buffer pool size.

    Table 15.9 Automatically Configured Log File Size

    Buffer Pool Size Log File Size
    Less than 8GB 512MiB
    8GB to 128GB 1024MiB
    Greater than 128GB 2048MiB

and all this parameters can be set defalut according to innodb_dedicated_server


You can refer to the following https://dev.mysql.com/doc/refman/8.0/en/innodb-dedicated-server.html Perhaps we can set these size flowing below:

and all this parameters can be set defalut according to [innodb_dedicated_server](https://dev.mysql.com/doc/refman/8.0/en/innodb-parameters.html#sysvar_innodb_dedicated_server)

@acekingke acekingke force-pushed the innodbLogFileSize branch from 60a9313 to 9a1cdb0 Compare June 6, 2022 04:10
@acekingke acekingke force-pushed the innodbLogFileSize branch from 9a1cdb0 to 30de970 Compare June 6, 2022 06:40
@runkecheng runkecheng requested a review from zhl003 June 15, 2022 07:07
Copy link
Collaborator

@zhl003 zhl003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@runkecheng runkecheng merged commit 6156546 into radondb:main Jun 15, 2022
@zhl003 zhl003 modified the milestones: Next, v2.2.0 Jun 15, 2022
zhl003 pushed a commit to zhl003/radondb-mysql-kubernetes that referenced this pull request Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature] innodb_log_file_size auto config.
3 participants