syncer: Optimize the logic of updating pod. #503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
runkecheng
force-pushed
the
fix_update_pod
branch
2 times, most recently
from
43be7d9 to
dc2e03e
Compare
|
Is related to: kubernetes/kubernetes#106059 |
|
andyli029
reviewed
May 31, 2022
runkecheng
force-pushed
the
fix_update_pod
branch
from
dc2e03e to
d649391
Compare
runkecheng
changed the title
runkecheng
force-pushed
the
fix_update_pod
branch
5 times, most recently
from
2e0c3c7 to
d0c94e0
Compare
updatedRevision wiil not update with the currentRevision when using `onDelete`. Use sfs.status.UpdatedRplicas and sfs.spec.Replicas to determine whether the update is completed.
runkecheng
force-pushed
the
fix_update_pod
branch
from
d0c94e0 to
134937d
Compare
acekingke
approved these changes
Jun 15, 2022
mysqlcluster/syncer/statefulset.go
Outdated
| @@ -298,7 +298,9 @@ func (s *StatefulSetSyncer) createOrUpdate(ctx context.Context) (controllerutil. | |||
| // updatePod update the pods, update follower nodes first. | |||
| // This can reduce the number of master-slave switching during the update process. | |||
| func (s *StatefulSetSyncer) updatePod(ctx context.Context) error { | |||
| if s.sfs.Status.UpdateRevision == s.sfs.Status.CurrentRevision { | |||
| // updatedRevision wiil not update with the currentRevision when using `onDelete`. | |||
zhl003
pushed a commit
to zhl003/radondb-mysql-kubernetes
that referenced
this pull request
Aug 17, 2022
* fix(cluster): update too many pods at the same time. * fix(cluster): adjust the exit logic of updatePod(). updatedRevision wiil not update with the currentRevision when using `onDelete`. Use sfs.status.UpdatedRplicas and sfs.spec.Replicas to determine whether the update is completed. * feat(cluster): actively switch leader to updated pod. * fix(cluster): wait pod healthy when updating
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/bug
/enhancement
Which issue(s) this PR fixes?
Fixes #502 #310
What this PR does?
Summary:
After deleting the pod, wait for the pod to restart.
Use updatedReplicas and Spec.replicas to judge if the updatepod() is needed.
Special notes for your reviewer?