-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: Init webhook. #487
Merged
Merged
*: Init webhook. #487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
runkecheng
force-pushed
the
feature_webhook
branch
4 times, most recently
from
May 17, 2022 03:11
ed7f82e
to
e4ab6fa
Compare
andyli029
reviewed
May 17, 2022
runkecheng
force-pushed
the
feature_webhook
branch
from
May 17, 2022 07:58
e4ab6fa
to
9c9a42c
Compare
runkecheng
force-pushed
the
feature_webhook
branch
from
May 18, 2022 06:29
9c9a42c
to
02d1190
Compare
andyli029
reviewed
May 20, 2022
andyli029
reviewed
May 20, 2022
kubebuilder create webhook --group mysql --version v1alpha1 --kind mysqlcluster --defaulting --programmatic-validation
1. Use helm generated cert. (Default) 2. Use cert-manager. (Set certManager.enabled to true and make sure that cert-manager has been installed.) 3. Use Specified cert. (Fill in caBundlePEM, crtPEM, keyPEM.)
runkecheng
force-pushed
the
feature_webhook
branch
from
May 20, 2022 06:26
02d1190
to
4729341
Compare
LGMT |
acekingke
approved these changes
May 23, 2022
andyli029
requested review from
acekingke and
andyli029
and removed request for
andyli029
May 23, 2022 13:22
andyli029
approved these changes
May 23, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
zhl003
pushed a commit
to zhl003/radondb-mysql-kubernetes
that referenced
this pull request
Aug 17, 2022
*: Init webhook.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/enhancement
Which issue(s) this PR fixes?
Fixes #486
What this PR does?
Summary:
Special notes for your reviewer?