Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: Init webhook. #487

Merged
merged 2 commits into from
May 23, 2022
Merged

*: Init webhook. #487

merged 2 commits into from
May 23, 2022

Conversation

runkecheng
Copy link
Collaborator

@runkecheng runkecheng commented May 17, 2022

What type of PR is this?

/enhancement

Which issue(s) this PR fixes?

Fixes #486

What this PR does?

Summary:

  • Init code of webhook, generated by kubebuilder.
  • Support install webhook by chart without additional operate.
  • Support certManager.

Special notes for your reviewer?

@runkecheng runkecheng added enhancement New feature or request chart labels May 17, 2022
@runkecheng runkecheng added this to the Next milestone May 17, 2022
@runkecheng runkecheng requested review from acekingke and andyli029 May 17, 2022 02:56
@runkecheng runkecheng force-pushed the feature_webhook branch 4 times, most recently from ed7f82e to e4ab6fa Compare May 17, 2022 03:11
kubebuilder create webhook --group mysql --version v1alpha1 --kind mysqlcluster --defaulting --programmatic-validation
1. Use helm generated cert. (Default)
2. Use cert-manager. (Set certManager.enabled to true and make sure that cert-manager has been installed.)
3. Use Specified cert. (Fill in caBundlePEM, crtPEM, keyPEM.)
@acekingke
Copy link
Contributor

LGMT

@andyli029 andyli029 requested review from acekingke and andyli029 and removed request for andyli029 May 23, 2022 13:22
Copy link
Contributor

@andyli029 andyli029 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andyli029 andyli029 modified the milestones: Next, v2.2.0, v2.2.1 May 24, 2022
zhl003 pushed a commit to zhl003/radondb-mysql-kubernetes that referenced this pull request Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chart enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature] Support webhook.
3 participants