Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: Add backup Name into Backup status #484

Merged
merged 1 commit into from
May 30, 2022
Merged

*: Add backup Name into Backup status #484

merged 1 commit into from
May 30, 2022

Conversation

acekingke
Copy link
Contributor

What type of PR is this?

/enhancement

Which issue(s) this PR fixes?

Fixes #453

What this PR does?

Summary:
Add BackupName in backup.Status

Special notes for your reviewer?

@acekingke acekingke added the enhancement New feature or request label May 13, 2022
@acekingke acekingke added this to the Next milestone May 13, 2022
@acekingke acekingke requested review from andyli029 and runkecheng May 13, 2022 08:59
@acekingke acekingke self-assigned this May 13, 2022
@acekingke acekingke changed the title Backup status Add backup Name into Backup status May 13, 2022
@acekingke acekingke changed the title Add backup Name into Backup status *: Add backup Name into Backup status May 13, 2022
@runkecheng
Copy link
Collaborator

add additionalPrinterColumns like:

kubectl get backup   
before:
NAME             AGE
backup-sample1   2s
backup-sample2   2s
after:
NAME             CLUSTER    NAMESPACE   COMPLETED    BACKUP-NAME   SECRET   TIME    
backup-sample1   sample1    default     true         sample_xxx    secret1  yyyy-mm-dd hh:mm:ss
backup-sample2   sample2    default     true         sample_yyy    secret2  yyyy-mm-dd hh:mm:ss

andyli029
andyli029 reviewed May 13, 2022
View reviewed changes
@andyli029
Copy link
Contributor

@acekingke
Code check / check-crd (pull_request) Failing after 56s — check-crd

@andyli029 andyli029 marked this pull request as draft May 17, 2022 08:49
@acekingke
Copy link
Contributor Author

@acekingke Code check / check-crd (pull_request) Failing after 56s — check-crd

it was fixed.

@acekingke acekingke marked this pull request as ready for review May 18, 2022 08:37
@acekingke acekingke requested a review from andyli029 May 25, 2022 07:58
@runkecheng runkecheng added the CRD label May 25, 2022
@andyli029 andyli029 modified the milestones: Next, v2.2.0 May 25, 2022
@andyli029
Copy link
Contributor

andyli029 commented May 26, 2022 •
edited
Loading

Ping @Nrehearsal from #453.

@andyli029 andyli029 requested a review from Nrehearsal May 26, 2022 00:43
@Nrehearsal
Copy link
Member

line here

@acekingke

there is a problem, if backup.spec.image was no set by user, we should set it with mysqlcluster.spec.podPolicy.sidecarImage. use the default value may cause some version compatibility issues

andyli029
andyli029 reviewed May 30, 2022
View reviewed changes
Copy link
Contributor

@andyli029 andyli029 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@andyli029 andyli029 merged commit 171acda into radondb:main May 30, 2022
zhl003 pushed a commit to zhl003/radondb-mysql-kubernetes that referenced this pull request Aug 17, 2022
@andyli029
Merge pull request radondb#484 from acekingke/BackupStatus
c8ab529 
*: Add backup Name  into Backup status
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyli029 andyli029 andyli029 left review comments

@Nrehearsal Nrehearsal Nrehearsal approved these changes

@runkecheng runkecheng runkecheng approved these changes

Assignees

@acekingke acekingke

Labels
CRD enhancement New feature or request
Projects
None yet
Milestone
v2.2.0
Development

Successfully merging this pull request may close these issues.

[feature] Provide more details of backup in spec->status of backup CRD
4 participants
@acekingke @runkecheng @andyli029 @Nrehearsal