Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: Lowcase table name forbid to modify in my.cnf #481

Merged
merged 1 commit into from
May 25, 2022

Conversation

acekingke
Copy link
Contributor

What type of PR is this?

/bug

Which issue(s) this PR fixes?

Fixes #477

What this PR does?

Summary:
Use webhook to forbidden the mysqlconf's modifies

Special notes for your reviewer?

go.mod Outdated Show resolved Hide resolved
config/samples/mysql_v1alpha1_mysqlcluster.yaml Outdated Show resolved Hide resolved
docs/en-us/deploy_radondb-mysql_operator_on_k8s.md Outdated Show resolved Hide resolved
@acekingke acekingke changed the title Lowcase table name *: Lowcase table name forbid to modify in my.cnf May 13, 2022
@acekingke acekingke force-pushed the lowcaseTableName branch 2 times, most recently from e66164b to 9180d8f Compare May 16, 2022 02:03
@acekingke acekingke requested review from andyli029 and runkecheng May 16, 2022 02:04
@runkecheng
Copy link
Collaborator

need rebase

api/v1alpha1/mysqlcluster_webhook.go Outdated Show resolved Hide resolved
api/v1alpha1/mysqlcluster_webhook.go Outdated Show resolved Hide resolved
@runkecheng runkecheng added webhook enhancement New feature or request labels May 25, 2022
@runkecheng runkecheng added this to the v2.2.0 milestone May 25, 2022
@andyli029 andyli029 modified the milestones: v2.2.0, v2.2.1 May 25, 2022
Copy link
Contributor

@andyli029 andyli029 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@andyli029 andyli029 merged commit 4821e07 into radondb:main May 25, 2022
zhl003 pushed a commit to zhl003/radondb-mysql-kubernetes that referenced this pull request Aug 17, 2022
*: Lowcase table name forbid to modify in my.cnf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request webhook
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature] forbidden lower_case_table_names modify in my.cnf
3 participants