Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: Save Xenon's metadata to config map. #447

Merged
merged 3 commits into from
Apr 13, 2022
Merged

*: Save Xenon's metadata to config map. #447

merged 3 commits into from
Apr 13, 2022

Conversation

runkecheng
Copy link
Collaborator

@runkecheng runkecheng commented Apr 13, 2022 •
edited
Loading

What type of PR is this?

/enhancement

Which issue(s) this PR fixes?

Fixes #406 #439

What this PR does?

Summary:

subpath -> configmap
subpath may not work in some conditions. see #439

  1. Rename configMapSyncer to mysqlCMSyncer.
  2. Add a Xenon Configmap which is used to save xenon data.
  3. Build peers.json according to the replicas.
  4. Make peers.json in init-sidecar.
  5. Xenon boot using existing peers.json.

Special notes for your reviewer?

@runkecheng
Revert "Merge pull request radondb#413 from runkecheng/save_xenon_met…
3375b1c 
…adata"

This reverts commit a6386c7, reversing
changes made to f6932c6.
@runkecheng runkecheng added duplicate This issue or pull request already exists enhancement New feature or request labels Apr 13, 2022
@runkecheng runkecheng added this to the Next milestone Apr 13, 2022
@runkecheng runkecheng self-assigned this Apr 13, 2022
andyli029
andyli029 reviewed Apr 13, 2022
View reviewed changes
Copy link
Contributor

@andyli029 andyli029 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add #439 to the commit log

@runkecheng runkecheng force-pushed the feature_use_cm_save_xenon_metadata branch 4 times, most recently from b82a27a to 7892d33 Compare April 13, 2022 07:12
@runkecheng
*: Rename mysql config and volume.
8669092
@runkecheng
*: Save Xenon's metadata to config map.
458143b 
subpath -> configmap
subpath may not work in some conditions.
1. Add a Xenon Configmap which is used to save xenon data.
2. Build peers.json according to the replicas.
3. Make peers.json in init-sidecar.
4. Xenon boot using existing peers.json.
@runkecheng runkecheng force-pushed the feature_use_cm_save_xenon_metadata branch from 7892d33 to 458143b Compare April 13, 2022 10:27
@andyli029 andyli029 requested a review from qianfen2021 April 13, 2022 11:18
@andyli029 andyli029 added the test test framework label Apr 13, 2022
@andyli029 andyli029 modified the milestones: Next, v2.2.0 Apr 13, 2022
andyli029
andyli029 reviewed Apr 13, 2022
View reviewed changes
Copy link
Contributor

@andyli029 andyli029 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@andyli029 andyli029 merged commit 58d822a into radondb:main Apr 13, 2022
@runkecheng runkecheng mentioned this pull request Apr 14, 2022
Closed
zhl003 pushed a commit to zhl003/radondb-mysql-kubernetes that referenced this pull request Aug 17, 2022
@andyli029
Merge pull request radondb#447 from runkecheng/feature_use_cm_save_xe…
8380f7c 
…non_metadata

*: Save Xenon's metadata to config map.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyli029 andyli029 andyli029 left review comments

@acekingke acekingke Awaiting requested review from acekingke

@qianfen2021 qianfen2021 Awaiting requested review from qianfen2021

Assignees

@runkecheng runkecheng

Labels
duplicate This issue or pull request already exists enhancement New feature or request test test framework
Projects
None yet
Milestone
v2.2.0
Development

Successfully merging this pull request may close these issues.

[feature] Save Xenon's metadata to persistent storage.
2 participants
@runkecheng @andyli029