Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: Add podAntiAffinity to default sample yaml. #371 #393

Merged
merged 1 commit into from
Mar 17, 2022

Conversation

runkecheng
Copy link
Collaborator

@runkecheng runkecheng commented Feb 28, 2022

What type of PR is this?

/documentation
/enhancement

Which issue(s) this PR fixes?

ref: #371

What this PR does?

Summary:

Add podAntiAffinity to default sample yaml.

Guarantee to schedule nodes to different physical machines

Special notes for your reviewer?

@runkecheng runkecheng added documentation Improvements or additions to documentation enhancement New feature or request labels Feb 28, 2022
@runkecheng runkecheng added this to the v2.1.3 milestone Feb 28, 2022
@runkecheng runkecheng self-assigned this Feb 28, 2022
@runkecheng runkecheng changed the title Add podAntiAffinity to default sample yaml. #371 config: Add podAntiAffinity to default sample yaml. #371 Feb 28, 2022
@andyli029
Copy link
Contributor

Improve the issue #371

Copy link
Contributor

@acekingke acekingke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@runkecheng
Copy link
Collaborator Author

Using a new sample file may be better, if the default configuration of anti-affinity can be unable to deploy in the verification environment.

@andyli029
Copy link
Contributor

andyli029 commented Mar 10, 2022

Using a new sample file may be better

+1

@runkecheng runkecheng force-pushed the add_pod_antiaffinity_to_sample branch from f239ae4 to 00f2d3a Compare March 14, 2022 03:45
Copy link
Contributor

@andyli029 andyli029 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@andyli029 andyli029 merged commit 4b5bc33 into radondb:main Mar 17, 2022
@qianfen2021 qianfen2021 added the ok to test test ok label Mar 22, 2022
zhl003 pushed a commit to zhl003/radondb-mysql-kubernetes that referenced this pull request Aug 17, 2022
…o_sample

config: Add podAntiAffinity to default sample yaml. radondb#371
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request ok to test test ok
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants