Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: support the cronjob to backup #215 #386

Merged
merged 1 commit into from
Jun 10, 2022
Merged

*: support the cronjob to backup #215 #386

merged 1 commit into from
Jun 10, 2022

Conversation

acekingke
Copy link
Contributor

What type of PR is this?

/enhancement

Which issue(s) this PR fixes?

Fixes #215

What this PR does?

Summary:

Special notes for your reviewer?

@acekingke acekingke marked this pull request as draft February 17, 2022 03:00
@acekingke acekingke self-assigned this Feb 17, 2022
@acekingke acekingke added the enhancement New feature or request label Feb 17, 2022
@acekingke acekingke added this to the Next milestone Feb 17, 2022
@runkecheng runkecheng linked an issue Feb 17, 2022 that may be closed by this pull request
[question] Whether scheduled backups are supported？ #374
Closed
@acekingke acekingke marked this pull request as ready for review February 24, 2022 03:51
andyli029
andyli029 previously approved these changes Mar 14, 2022
View reviewed changes
Copy link
Contributor

@andyli029 andyli029 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add sample yaml.

@andyli029 andyli029 self-requested a review May 16, 2022 06:56
@andyli029
Copy link
Contributor

Resolve conflicts.

@Nrehearsal
Copy link
Member

line here

@acekingke

backup.CronJob.Image should be set in func (j *CronJob) Run() by fetching mysqlcluster, putting cluster-related variables into memory will cause data to be out of sync

@andyli029 andyli029 dismissed their stale review May 30, 2022 09:42

Resolve conflicts.

@andyli029 andyli029 modified the milestones: Next, v2.2.0 May 30, 2022
@acekingke
Copy link
Contributor Author

line here

@acekingke

backup.CronJob.Image should be set in func (j *CronJob) Run() by fetching mysqlcluster, putting cluster-related variables into memory will cause data to be out of sync

is fixed.

@Nrehearsal
Copy link
Member

line here
@acekingke
backup.CronJob.Image should be set in func (j *CronJob) Run() by fetching mysqlcluster, putting cluster-related variables into memory will cause data to be out of sync

is fixed.

get!

@acekingke acekingke requested a review from zhl003 June 10, 2022 03:04
zhl003
zhl003 approved these changes Jun 10, 2022
View reviewed changes
Copy link
Collaborator

@zhl003 zhl003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

andyli029
andyli029 approved these changes Jun 10, 2022
View reviewed changes
Copy link
Contributor

@andyli029 andyli029 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@andyli029 andyli029 merged commit a060161 into radondb:main Jun 10, 2022
zhl003 pushed a commit to zhl003/radondb-mysql-kubernetes that referenced this pull request Aug 17, 2022
@andyli029
Merge pull request radondb#386 from acekingke/CronJOBONE
c64f4df 
*: support the cronjob to backup radondb#215
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhl003 zhl003 zhl003 approved these changes

@andyli029 andyli029 andyli029 approved these changes

@runkecheng runkecheng runkecheng approved these changes

Assignees

@acekingke acekingke

Labels
enhancement New feature or request
Projects
None yet
Milestone
v2.2.0
Development

Successfully merging this pull request may close these issues.

[question] Whether scheduled backups are supported？ [Feature] support the cronjob to backup
5 participants
@acekingke @andyli029 @Nrehearsal @zhl003 @runkecheng