Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*:update replicas without restart #282

Merged

Conversation

runkecheng
Copy link
Collaborator

@runkecheng runkecheng commented Nov 3, 2021

What type of PR is this?

/bug
/enhancement

Which issue(s) this PR fixes?

Fixes #221

What this PR does?

Summary: Before the state is set to ready, check raft status and synchronize raft according to the spec.replicas.

Special notes for your reviewer?

@runkecheng runkecheng linked an issue Nov 4, 2021 that may be closed by this pull request
@runkecheng runkecheng force-pushed the feature_update_node_without_restart branch 3 times, most recently from e9f31d6 to d3be89a Compare November 4, 2021 09:27
@runkecheng runkecheng force-pushed the feature_update_node_without_restart branch 2 times, most recently from b549dc1 to 79f3fc6 Compare November 18, 2021 02:24
@runkecheng runkecheng force-pushed the feature_update_node_without_restart branch 3 times, most recently from 7021d98 to 5d7151c Compare November 18, 2021 03:32
@runkecheng runkecheng marked this pull request as ready for review November 18, 2021 06:12
@runkecheng runkecheng self-assigned this Nov 18, 2021
@runkecheng runkecheng added the enhancement New feature or request label Nov 18, 2021
@runkecheng runkecheng added this to the v2.1.1 milestone Nov 18, 2021
@runkecheng runkecheng force-pushed the feature_update_node_without_restart branch 3 times, most recently from e618100 to c9f8d86 Compare November 19, 2021 07:50
@acekingke
Copy link
Contributor

LGTM

Copy link
Contributor

@andyli029 andyli029 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Relicas-> Replicas

@runkecheng runkecheng force-pushed the feature_update_node_without_restart branch from c9f8d86 to df70898 Compare November 23, 2021 03:17
@runkecheng runkecheng force-pushed the feature_update_node_without_restart branch from df70898 to f161f8a Compare November 23, 2021 03:46
Copy link
Contributor

@andyli029 andyli029 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@andyli029 andyli029 merged commit 98a9110 into radondb:main Nov 23, 2021
zhl003 pushed a commit to zhl003/radondb-mysql-kubernetes that referenced this pull request Aug 17, 2022
…thout_restart

*:update replicas without restart
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature] Support change replicas without restart cluster.
3 participants