Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: Support automatic check code format specification and run unit tests. #277

Merged
merged 2 commits into from
Oct 27, 2021

Conversation

runkecheng
Copy link
Collaborator

What type of PR is this?

/enhancement

Which issue(s) this PR fixes?

Fixes #276

What this PR does?

Summary:

  • Automatically use the following function to check the submitted code.

    • gofmt
    • staticcheck
  • Automatically perform the corresponding unit test based on the updated folder.

  • Automatically check if the CRD definition is all consistent.

  • Fix some formats and specifications.

Special notes for your reviewer?

@runkecheng runkecheng added enhancement New feature or request format format labels Oct 25, 2021
@runkecheng runkecheng added this to the v2.1.1 milestone Oct 25, 2021
@runkecheng runkecheng self-assigned this Oct 25, 2021
@hustjieke
Copy link
Contributor

ping @qianfen2021

@runkecheng
Copy link
Collaborator Author

@hustjieke Need your REVIEW

@acekingke
Copy link
Contributor

LGTM

@andyli029
Copy link
Contributor

LGTM.

@andyli029 andyli029 merged commit 607f760 into radondb:main Oct 27, 2021
zhl003 pushed a commit to zhl003/radondb-mysql-kubernetes that referenced this pull request Aug 17, 2022
*: Support automatic check code format specification and run unit tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request format format workflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature]workflow: Automatic format check and unit test using Github Action.
4 participants