Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: Fix the setting method of innodb_buffer_pool_instances parameter and change podSpec.Resources name. #244 #265

Merged
merged 2 commits into from
Oct 28, 2021

Conversation

runkecheng
Copy link
Collaborator

@runkecheng runkecheng commented Oct 15, 2021

What type of PR is this?

/enhancement

Which issue(s) this PR fixes?

Fixes #244

What this PR does?

Summary:

  • PodSpec.Resources ->PodPolicy.defaultResources
  • The method of calculating innodb_buffer_pool_instances is changed from using podSpec.Resources to using mysqlOpts.Resources

Special notes for your reviewer?

@runkecheng runkecheng added the bug Something isn't working label Oct 15, 2021
@runkecheng runkecheng added this to the Next milestone Oct 15, 2021
@runkecheng runkecheng self-assigned this Oct 15, 2021
@runkecheng
Copy link
Collaborator Author

after modification:

    Resources:
      Limits:
        Cpu:     4000m
        Memory:  8Gi
      Requests:
        Cpu:        2000m
        Memory:     4Gi
  • innodb_buffer_pool_instances should be 2. √
  • innodb_buffer_pool_size should be 2.5G(it must be an integer multiple of innodb_buffer_pool_chunk_size * innodb_buffer_pool_instances). √
mysql> SHOW VARIABLES LIKE 'innodb_buffer_pool_%';
+-------------------------------------+----------------+
| Variable_name                       | Value          |
+-------------------------------------+----------------+
| innodb_buffer_pool_instances        | 2              |
| innodb_buffer_pool_size             | 2684354560     |
+-------------------------------------+----------------+
11 rows in set (0.01 sec)

@acekingke
Copy link
Contributor

LGTM

@runkecheng runkecheng force-pushed the fix_buffer branch 3 times, most recently from 94fc6fb to 40965db Compare October 28, 2021 02:14
@hustjieke
Copy link
Contributor

LGTM.

@andyli029
Copy link
Contributor

LGTM.

@andyli029 andyli029 merged commit f6df9f4 into radondb:main Oct 28, 2021
zhl003 pushed a commit to zhl003/radondb-mysql-kubernetes that referenced this pull request Aug 17, 2022
*: Fix the setting method of innodb_buffer_pool_instances parameter and change podSpec.Resources name. radondb#244
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] The EnsureMysqlConf function calculates mysql parameters incorrectly.
4 participants