-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: Fix the setting method of innodb_buffer_pool_instances parameter and change podSpec.Resources name. #244 #265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
runkecheng
requested review from
acekingke,
andyli029,
hustjieke and
qianfen2021
October 15, 2021 02:45
after modification:
|
LGTM |
runkecheng
force-pushed
the
fix_buffer
branch
from
October 19, 2021 02:18
7a5bfc6
to
c288a1c
Compare
hustjieke
reviewed
Oct 19, 2021
runkecheng
force-pushed
the
fix_buffer
branch
3 times, most recently
from
October 28, 2021 02:14
94fc6fb
to
40965db
Compare
andyli029
reviewed
Oct 28, 2021
LGTM. |
runkecheng
force-pushed
the
fix_buffer
branch
from
October 28, 2021 02:58
40965db
to
622603c
Compare
andyli029
reviewed
Oct 28, 2021
runkecheng
force-pushed
the
fix_buffer
branch
from
October 28, 2021 03:39
622603c
to
c1f5133
Compare
runkecheng
force-pushed
the
fix_buffer
branch
from
October 28, 2021 03:46
c1f5133
to
e576ccb
Compare
runkecheng
force-pushed
the
fix_buffer
branch
from
October 28, 2021 04:04
e576ccb
to
47dfde6
Compare
LGTM. |
zhl003
pushed a commit
to zhl003/radondb-mysql-kubernetes
that referenced
this pull request
Aug 17, 2022
*: Fix the setting method of innodb_buffer_pool_instances parameter and change podSpec.Resources name. radondb#244
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/enhancement
Which issue(s) this PR fixes?
Fixes #244
What this PR does?
Summary:
PodSpec.Resources
->PodPolicy.defaultResources
innodb_buffer_pool_instances
is changed from usingpodSpec.Resources
to usingmysqlOpts.Resources
Special notes for your reviewer?