*: Optimize the logic of creating sqlrunner. #229 #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyli029
reviewed
Sep 22, 2021
andyli029
reviewed
Sep 22, 2021
runkecheng
force-pushed
the
sqlrunner
branch
3 times, most recently
from
9a6901f to
db0c59f
Compare
runkecheng
force-pushed
the
sqlrunner
branch
from
db0c59f to
9cffaf6
Compare
andyli029
reviewed
Sep 24, 2021
runkecheng
force-pushed
the
sqlrunner
branch
3 times, most recently
from
b278546 to
6c20582
Compare
acekingke
reviewed
Sep 24, 2021
runkecheng
force-pushed
the
sqlrunner
branch
from
6c20582 to
a57d83f
Compare
acekingke
reviewed
Sep 24, 2021
runkecheng
force-pushed
the
sqlrunner
branch
from
a57d83f to
a22dfb2
Compare
|
LGTM |
zhl003
pushed a commit
to zhl003/radondb-mysql-kubernetes
that referenced
this pull request
Aug 17, 2022
*: Optimize the logic of creating sqlrunner. radondb#229
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Optimize the logic of creating sqlrunner.
Which issue(s) this PR fixes?
Fixes #229
What this PR does?
Summary: Apply the necessary configuration to SQLRunnerFactory to create the corresponding sqlrunner, which simplifies the creation process of sqlrunner.
Special notes for your reviewer?