Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature fix bug of not effective version of mysql56 #203 #217

Conversation

hustjieke
Copy link
Contributor

What type of PR is this?

Which issue(s) this PR fixes?

Fixes #

What this PR does?

Summary:

Special notes for your reviewer?

@hustjieke hustjieke added bug Something isn't working enhancement New feature or request labels Sep 10, 2021
@hustjieke hustjieke modified the milestones: Next, v2.1.0 Sep 10, 2021
@hustjieke hustjieke self-assigned this Sep 10, 2021
@hustjieke hustjieke marked this pull request as ready for review September 24, 2021 08:40
@andyli029 andyli029 modified the milestones: v2.1.0, v2.1.1 Sep 24, 2021
@andyli029
Copy link
Contributor

Resolve conflicts.

[summary]
rm uneffective version of mysql56, currently we do not support mysql 5.6
or lower version

[test case]
N/A

[patch codecov]
N/A
@hustjieke hustjieke force-pushed the feature_fix_bug_of_not_effective_version_of_mysql56_#203 branch 2 times, most recently from 47b51ad to 08ec87f Compare November 3, 2021 02:43
@hustjieke
Copy link
Contributor Author

Resolve conflicts.

Resolved.

@hustjieke hustjieke force-pushed the feature_fix_bug_of_not_effective_version_of_mysql56_#203 branch from 08ec87f to fb29149 Compare November 3, 2021 08:01
Copy link
Contributor

@andyli029 andyli029 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@andyli029 andyli029 merged commit a62c4cc into radondb:main Nov 11, 2021
zhl003 pushed a commit to zhl003/radondb-mysql-kubernetes that referenced this pull request Aug 17, 2022
…effective_version_of_mysql56_#203

Feature fix bug of not effective version of mysql56 radondb#203
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants