Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: add serviceMonitor for operator #169 #174

Merged
merged 1 commit into from
Aug 23, 2021
Merged

Conversation

runkecheng
Copy link
Collaborator

@runkecheng runkecheng commented Aug 6, 2021

What type of PR is this?

/enhancement

Which issue(s) this PR fixes?

Fixes #169

What this PR does?

Summary:

  • install servicemonitor when install operator.
  • create metrics service when metrics enable

Special notes for your reviewer?

For testing, please set the manager image in charts/mysql-operator/values.yaml to runkecheng/mysql-operator and set config/samples/mysql_v1alpha1_cluster.yaml :

metricsOpts:
    enabled: true

If you are using qke, you can configure port forwarding for the prometheus-k8s service which under kubesphere-monitoring-system ns, and then you can access prometheus through the external network and view related data interfaces.

@runkecheng runkecheng force-pushed the monitor branch 2 times, most recently from dad6356 to 388893d Compare August 9, 2021 03:02
@andyli029
Copy link
Contributor

Commit log add:

config/samples/mysql_v1alpha1_cluster.yaml

   metricsOpts:
        enabled: true

@runkecheng runkecheng force-pushed the monitor branch 5 times, most recently from 6538d5e to 2ffdd62 Compare August 23, 2021 07:52
…utomatically create a new monitoring service when the metrics container is enabled radondb#169
Copy link
Contributor

@andyli029 andyli029 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@andyli029 andyli029 merged commit 6d834b7 into radondb:main Aug 23, 2021
@runkecheng runkecheng deleted the monitor branch October 29, 2021 02:08
zhl003 pushed a commit to zhl003/radondb-mysql-kubernetes that referenced this pull request Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature] Add ServiceMonitor for operator
3 participants