Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

syncer: support external network access service and automatic expose metrics port #156 #160

Closed
wants to merge 2 commits into from

Conversation

runkecheng
Copy link
Collaborator

What type of PR is this?

/enhancement

Which issue(s) this PR fixes?

this pr is for metrics feature, custom monitoring panel in k8e needs to expose the ports of the metrics container,
and users may need to use other monitoring panels outside of k8e.

Fixes #156

What this PR does?

Summary:

  1. The external network access mode is fixed to ClusterIP, and editing is not allowed -> Editing is allowed, the default is ClusterIP
  2. Editing the service port is not allowed, the mysql port is exposed by default -> If metrics is enabled, metrics port will be automatically exposed
  3. move manager and sidecar images to radondb(Already repackaged)

Special notes for your reviewer?

Test whether it meets expectations through installation

@runkecheng runkecheng changed the title syncer: support external network access monitor #156 syncer: support external network access monitor and automatic expose metrics port #156 Aug 2, 2021
@runkecheng runkecheng changed the title syncer: support external network access monitor and automatic expose metrics port #156 syncer: support external network access service and automatic expose metrics port #156 Aug 2, 2021
@runkecheng runkecheng added the enhancement New feature or request label Aug 2, 2021
@runkecheng runkecheng force-pushed the latest branch 2 times, most recently from 872002d to 01a3737 Compare August 2, 2021 09:43
@andyli029 andyli029 added this to the v1.3.0 milestone Aug 3, 2021
Copy link
Contributor

@acekingke acekingke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@runkecheng runkecheng closed this Aug 3, 2021
@runkecheng runkecheng deleted the latest branch October 29, 2021 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature] Support external network access monitor
3 participants