Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: backup to S3 and restore from S3 #116 #144

Closed
wants to merge 11 commits into from
Closed

*: backup to S3 and restore from S3 #116 #144

wants to merge 11 commits into from

Conversation

acekingke
Copy link
Contributor

What type of PR is this?

/enhancement

Which issue(s) this PR fixes?

Fixes #116

What this PR does?

Summary:
use S3 backup cluster and restore cluster from S3

Special notes for your reviewer?

andyli029
andyli029 reviewed Jul 15, 2021
View reviewed changes
PROJECT Outdated Show resolved Hide resolved
@andyli029 andyli029 added this to the v1.3.0 milestone Jul 16, 2021
zhyass
zhyass reviewed Jul 16, 2021
View reviewed changes
Copy link
Contributor

@zhyass zhyass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job !

Dockerfile.sidecar Outdated Show resolved Hide resolved
backup/syncer/job.go Outdated Show resolved Hide resolved
utils/constants.go Outdated Show resolved Hide resolved
utils/common.go Show resolved Hide resolved
sidecar/util.go Show resolved Hide resolved
cmd/sidecar/main.go Outdated Show resolved Hide resolved
backup/syncer/job.go Outdated Show resolved Hide resolved
backup/status.go Outdated Show resolved Hide resolved
backup/status.go Outdated Show resolved Hide resolved
api/v1alpha1/backup_types.go Show resolved Hide resolved
@andyli029
Copy link
Contributor

andyli029 commented Jul 20, 2021 •
edited
Loading

Fix the places pointed out by others first:
#138
@acekingke

zhyass
zhyass reviewed Jul 20, 2021
View reviewed changes
api/v1alpha1/backup_types.go Show resolved Hide resolved
api/v1alpha1/backup_types.go Show resolved Hide resolved
backup/syncer/job.go Outdated Show resolved Hide resolved
config/rbac/backup_viewer_role.yaml Outdated Show resolved Hide resolved
sidecar/server.go Outdated Show resolved Hide resolved
zhyass
zhyass reviewed Jul 20, 2021
View reviewed changes
docs/DEPLOY.md Outdated Show resolved Hide resolved
@zhyass
Copy link
Contributor

zhyass commented Jul 20, 2021

LGTM

zhyass
zhyass reviewed Jul 22, 2021
View reviewed changes
sidecar/config.go Outdated Show resolved Hide resolved
runkecheng
runkecheng reviewed Jul 26, 2021
View reviewed changes
docs/DEPLOY.md Outdated Show resolved Hide resolved
@runkecheng runkecheng mentioned this pull request Jul 27, 2021
Closed
@andyli029 andyli029 modified the milestones: v1.3.0, Next Aug 10, 2021
@acekingke acekingke added the enhancement New feature or request label Aug 18, 2021
@andyli029
Copy link
Contributor

Version: 0.1.88

@TCeason
Copy link

TCeason commented Aug 19, 2021

Version: 0.1.88

It's really a good pr. When can we use it on master？

@andyli029
Copy link
Contributor

Version: 0.1.88

It's really a good pr. When can we use it on master？

Soon.

@TCeason
Copy link

TCeason commented Aug 19, 2021

Version: 0.1.88

It's really a good pr. When can we use it on master？

Soon.

Pretty good.

andyli029
andyli029 reviewed Aug 20, 2021
View reviewed changes
docs/DEPLOY.md Outdated Show resolved Hide resolved
@andyli029 andyli029 mentioned this pull request Aug 20, 2021
Closed
@andyli029 andyli029 mentioned this pull request Aug 24, 2021
Closed
@andyli029 andyli029 mentioned this pull request Aug 24, 2021
Closed
@acekingke acekingke closed this Aug 25, 2021
@andyli029 andyli029 mentioned this pull request Aug 25, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@runkecheng runkecheng runkecheng left review comments

@zhyass zhyass zhyass left review comments

@andyli029 andyli029 andyli029 left review comments

@TCeason TCeason Awaiting requested review from TCeason

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v2.1.0
Development

Successfully merging this pull request may close these issues.

[feature]add xtrabackup manger
5 participants
@acekingke @andyli029 @zhyass @TCeason @runkecheng