Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: support roll update #133

Merged
merged 5 commits into from
Jul 27, 2021
Merged

*: support roll update #133

merged 5 commits into from
Jul 27, 2021

Conversation

zhyass
Copy link
Contributor

@zhyass zhyass commented Jul 8, 2021 •
edited
Loading

What type of PR is this?

/enhancement

Which issue(s) this PR fixes?

Fixes #121

What this PR does?

Summary:

Upgrade the follower nodes first, and then upgrade the leader node last.

Special notes for your reviewer?

@zhyass zhyass marked this pull request as draft July 8, 2021 10:09
@zhyass zhyass added enhancement New feature or request P0 High priority labels Jul 8, 2021
@zhyass zhyass self-assigned this Jul 8, 2021
@zhyass zhyass requested a review from andyli029 July 8, 2021 10:10
@zhyass zhyass force-pushed the upgrade branch 2 times, most recently from ed890df to 66f4b64 Compare July 9, 2021 03:13
@andyli029 andyli029 added this to the v1.3.0 milestone Jul 9, 2021
andyli029
andyli029 reviewed Jul 12, 2021
View reviewed changes
Copy link
Contributor

@andyli029 andyli029 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need add logic to cluster about two nodes.

@zhyass zhyass force-pushed the upgrade branch 4 times, most recently from b699bfd to 497ca6a Compare July 14, 2021 06:02
@zhyass zhyass marked this pull request as ready for review July 14, 2021 10:37
@zhyass zhyass requested a review from andyli029 July 14, 2021 10:42
@zhyass zhyass force-pushed the upgrade branch 7 times, most recently from cd8a830 to 991a42a Compare July 15, 2021 10:31
@zhyass zhyass requested a review from acekingke July 20, 2021 08:18
andyli029
andyli029 reviewed Jul 21, 2021
View reviewed changes
Copy link
Contributor

@andyli029 andyli029 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ping @acekingke

acekingke
acekingke reviewed Jul 22, 2021
View reviewed changes
api/v1alpha1/cluster_types.go Show resolved Hide resolved
cluster/syncer/secret.go Show resolved Hide resolved
internal/sql_runner.go Show resolved Hide resolved
sidecar/init.go Outdated Show resolved Hide resolved
@andyli029 andyli029 mentioned this pull request Jul 23, 2021
Closed
@andyli029
Copy link
Contributor

andyli029 commented Jul 23, 2021 •
edited
Loading

Fix :#149
Rebase first and fix it

@zhyass zhyass force-pushed the upgrade branch 2 times, most recently from 0789ed6 to 9febb6d Compare July 23, 2021 07:55
acekingke
acekingke reviewed Jul 23, 2021
View reviewed changes
sidecar/config.go Show resolved Hide resolved
cluster/syncer/statefulset.go Show resolved Hide resolved
cluster/syncer/status.go Outdated Show resolved Hide resolved
@zhyass zhyass force-pushed the upgrade branch 3 times, most recently from 88990f9 to 43e6535 Compare July 26, 2021 10:40
acekingke
acekingke reviewed Jul 27, 2021
View reviewed changes
cluster/syncer/statefulset.go Outdated Show resolved Hide resolved
testbin/setup-envtest.sh Outdated Show resolved Hide resolved
@zhyass zhyass force-pushed the upgrade branch 2 times, most recently from 2e9ee3a to d85cece Compare July 27, 2021 08:06
@acekingke
Copy link
Contributor

LGTM

@andyli029 andyli029 merged commit 1a451fe into radondb:main Jul 27, 2021
@runkecheng runkecheng mentioned this pull request Aug 3, 2021
Closed
zhl003 pushed a commit to zhl003/radondb-mysql-kubernetes that referenced this pull request Aug 17, 2022
@andyli029
Merge pull request radondb#133 from zhyass/upgrade
57d8e61 
*: support roll update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyli029 andyli029 andyli029 left review comments

@acekingke acekingke acekingke left review comments

Assignees

@zhyass zhyass

Labels
enhancement New feature or request P0 High priority
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging this pull request may close these issues.

[feature] support rolling update
3 participants
@zhyass @andyli029 @acekingke