Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature] fix 5.7.33 to 5.7.34 #200

Closed
hustjieke opened this issue Aug 26, 2021 · 1 comment · Fixed by #205
Closed

[feature] fix 5.7.33 to 5.7.34 #200

hustjieke opened this issue Aug 26, 2021 · 1 comment · Fixed by #205
Labels
enhancement New feature or request

Comments

@hustjieke
Copy link
Contributor

Is your feature request related to a problem? Please describe.

Describe the solution you'd like

Describe alternatives you've considered

cluster/container/init_sidecar_test.go:104:			Value: "5.7.33",
cluster/container/mysql_test.go:55:	assert.Equal(t, "percona/percona-server:5.7.33", mysqlCase.Image)
cluster/container/init_mysql_test.go:108:	assert.Equal(t, "percona/percona-server:5.7.33", initMysqlCase.Image)
docs/others/setup-rw-svc.md:74:Server version: 5.7.33-36-log Percona Server (GPL), Release '36', Revision '7e403c5'
utils/constants.go:21:	MySQLDefaultVersion = "5.7.33"
utils/constants.go:25:		"5.7": "5.7.33",
utils/constants.go:30:		"5.7.33": "percona/percona-server:5.7.33",

Additional context

releated to #123
@hustjieke hustjieke added the enhancement New feature or request label Aug 26, 2021
@zhyass
Copy link
Contributor

zhyass commented Sep 3, 2021

In https://github.com/radondb/radondb-mysql-kubernetes/blob/main/utils/constants.go#L30 we have a list of the support version, such as 5.7.33, 5.7.34.
Reference: https://github.com/bitpoke/mysql-operator/blob/master/pkg/util/constants/constants.go#L94

@zhyass zhyass mentioned this issue Sep 3, 2021
Merged
@hustjieke hustjieke linked a pull request Sep 9, 2021 that will close this issue
*.: fix default mysql version 5.7.33 to 5.7.34 #205
Merged
hustjieke added a commit to hustjieke/radondb-mysql-kubernetes that referenced this issue Sep 9, 2021
@hustjieke
*.: fix default mysql version 5.7.33 to 5.7.34 radondb#200
af64495 
[summary]
change default mysql version to 5.7.34 and add it to tag list
hustjieke added a commit to hustjieke/radondb-mysql-kubernetes that referenced this issue Sep 9, 2021
@hustjieke
*.: fix default mysql version 5.7.33 to 5.7.34 radondb#200
d7761d6 
[summary]
change default mysql version to 5.7.34 and add it to tag list
zhl003 pushed a commit to zhl003/radondb-mysql-kubernetes that referenced this issue Aug 17, 2022
@hustjieke
*.: fix default mysql version 5.7.33 to 5.7.34 radondb#200
28762a0 
[summary]
change default mysql version to 5.7.34 and add it to tag list
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

*.: fix default mysql version 5.7.33 to 5.7.34 hustjieke/radondb-mysql-kubernetes
2 participants
@hustjieke @zhyass