cluster: fix the bug about status #158

radondb · Aug 3, 2021 · e820782 · e820782
1 parent f6f8441
commit e820782
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/cluster/syncer/statefulset.go b/cluster/syncer/statefulset.go
@@ -185,7 +185,8 @@ func (s *StatefulSetSyncer) updatePod(ctx context.Context) error {
 	log.Info("statefulSet was changed, run update")
 
 	if s.sfs.Status.ReadyReplicas < s.sfs.Status.Replicas {
-		return fmt.Errorf("can't start/continue 'update': waiting for all replicas are ready")
+		log.Info("can't start/continue 'update': waiting for all replicas are ready")
+		return nil
 	}
 
 	pods := corev1.PodList{}

diff --git a/cluster/syncer/status.go b/cluster/syncer/status.go
@@ -226,7 +226,9 @@ func (s *StatusSyncer) updateNodeStatus(ctx context.Context, cli client.Client,
 			log.Error(err, "cannot update pod", "name", podName, "namespace", pod.Namespace)
 		}
 	}
-
+	if len(pods) != int(*s.Spec.Replicas) {
+		return fmt.Errorf("not all replicas do something")
+	}
 	return nil
 }