backup:fix s3 backup empty env

radondb · Apr 28, 2023 · e3b9004 · e3b9004
1 parent df6312b
commit e3b9004
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/controllers/backup/backup_controller.go b/controllers/backup/backup_controller.go
@@ -504,8 +504,10 @@ func generateBackupJobSpec(backup *v1beta1.Backup, cluster *v1beta1.MysqlCluster
 		getEnvVarFromSecret(clusterAuthsctName, "BACKUP_USER", "backup-user", true),
 		getEnvVarFromSecret(clusterAuthsctName, "BACKUP_PASSWORD", "backup-password", true),
 	)
-	if NFSBackupEnv != nil && S3BackuptEnv != nil {
+	if NFSBackupEnv != nil {
 		container.Env = append(container.Env, *NFSBackupEnv)
+	}
+	if len(S3BackuptEnv) != 0 {
 		container.Env = append(container.Env, S3BackuptEnv...)
 	}