[AlertDialog][ContextMenu][Dialog][Popover][DropdownMenu] Fix pointer-events reset #819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andy-hook
approved these changes
Aug 11, 2021
|
👀 👀 👀 Seems like this would fix this? https://codesandbox.io/s/friendly-noyce-rin40 |
Yep, this change resolves it 👍 |
| @@ -33,6 +33,7 @@ function useBodyPointerEvents({ disabled }: { disabled: boolean }) { | |||
| } | |||
|
|
|||
| function resetPointerEvents() { | |||
| changeCount--; | |||
There was a problem hiding this comment.
I think that's my bad on this one, when we rejigged the code before I went on holidays I didn't catch that this bit wasn't moved with it.
There was a problem hiding this comment.
Nah, my fault for not moving it 😅 complete oversight.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pointer events were not resetting correctly when pop ups were opening from within other pop ups. This was initially reported here regarding
Dropdown/Dialogcomposition: https://discord.com/channels/752614004387610674/803656530259738674/874553651417477162This change ensures we decrease the count at the same time as the reset (when the unmount events have executed).