Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include 2023-10-01-preview in Microsoft.Resources/deployments manifest #8299

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

willdavsmith
Copy link
Contributor

@willdavsmith willdavsmith commented Jan 24, 2025

Description

I've been seeing some issues when trying to create resources on the Microsoft.Deployments/resources endpoint with api-version=2023-10-01-preview. I'm wondering if this is intentional behavior (I should change my use-case) or something we missed?

{
          "error": {
            "code": "BadRequest",
            "message": "api version \"2023-10-01-preview\" is not supported for resource type \"Microsoft.Resources/deployments\" by location \"global\"",
            "target": "/planes/radius/local/resourcegroups/default/providers/Microsoft.Resources/deployments/dt-env"
          }
        }

Type of change

  • This pull request is a minor refactor, code cleanup, test improvement, or other maintenance task and doesn't change the functionality of Radius (issue link optional).

Contributor checklist

Please verify that the PR meets the following requirements, where applicable:

  • An overview of proposed schema changes is included in a linked GitHub issue.
    • Yes
    • Not applicable
  • A design document PR is created in the design-notes repository, if new APIs are being introduced.
    • Yes
    • Not applicable
  • The design document has been reviewed and approved by Radius maintainers/approvers.
    • Yes
    • Not applicable
  • A PR for the samples repository is created, if existing samples are affected by the changes in this PR.
    • Yes
    • Not applicable
  • A PR for the documentation repository is created, if the changes in this PR affect the documentation or any user facing updates are made.
    • Yes
    • Not applicable
  • A PR for the recipes repository is created, if existing recipes are affected by the changes in this PR.
    • Yes
    • Not applicable

@willdavsmith willdavsmith requested review from a team as code owners January 24, 2025 20:03
@willdavsmith willdavsmith changed the title Include 2023-10-01-preview in Include 2023-10-01-preview in Microsoft.Resources/deployments manifest Jan 24, 2025
Copy link

codecov bot commented Jan 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.82%. Comparing base (7797bb0) to head (b7ee135).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8299   +/-   ##
=======================================
  Coverage   59.81%   59.82%           
=======================================
  Files         590      590           
  Lines       39513    39513           
=======================================
+ Hits        23636    23639    +3     
+ Misses      14116    14114    -2     
+ Partials     1761     1760    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lakshmimsft
Copy link
Contributor

lakshmimsft commented Jan 24, 2025

This is intentional and manifests referred above were recently updated to the valid versions. pls update version to "2020-10-01"
ref:

DeploymentsClientAPIVersion = "2020-10-01"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants