Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore bicep artifacts before starting tests #8283

Merged
merged 13 commits into from
Jan 27, 2025
Merged

Restore bicep artifacts before starting tests #8283

Changes from 6 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
e8f3fdf
restore bicep artifacts before starting tests
sk593 Jan 23, 2025
d0533fd
testing
sk593 Jan 23, 2025
b04c3e7
revert
sk593 Jan 23, 2025
c8123fe
nit
sk593 Jan 23, 2025
e2a499b
Merge branch 'main' into fix-flaky-aws-restoration
sk593 Jan 23, 2025
0255e45
Merge branch 'main' into fix-flaky-aws-restoration
sk593 Jan 24, 2025
7654a24
update to restore
sk593 Jan 24, 2025
71d2e24
nit
sk593 Jan 24, 2025
a000290
revert
sk593 Jan 24, 2025
21bcabd
Merge branch 'main' into fix-flaky-aws-restoration
sk593 Jan 27, 2025
d494007
Merge branch 'main' into fix-flaky-aws-restoration
sk593 Jan 27, 2025
147b080
add comments
sk593 Jan 27, 2025
744f451
Merge branch 'main' into fix-flaky-aws-restoration
sk593 Jan 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .github/workflows/functional-test-cloud.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -758,6 +758,12 @@ jobs:
}
}
EOF
- name: Restore Bicep artifacts before running functional tests
run: |
# Restore Radius Bicep types
bicep build ./test/functional-portable/corerp/cloud/resources/testdata/corerp-azure-connection-database-service.bicep
# Restore AWS Bicep types
bicep build ./test/functional-portable/corerp/cloud/resources/testdata/aws-s3-bucket.bicep
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do the tests need the files generated by these two commands to be able to run successfully? If so, should we add those files to the repository itself?

I think that to be able to run these tests locally, this is also something we need to run. Is that right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, they're not needed. They're an output of the build command but we're more interested in the artifacts being restored in this step.

Yes to the second question. The bicep build command gets run when we deploy bicep templates. bicep build automatically restores the artifacts which might be why we've been seeing flaky restoration failures. This change is added so the bicep artifacts are restored before the tests start and bicep build is run

- name: Run functional tests
run: |
# Ensure rad cli is in path before running tests.
Expand Down
Loading