chore: basic typing annotations #428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auto-merge was automatically disabled
March 18, 2024 19:40
Pull request was converted to draft
hairmare
force-pushed
the
chore/more-mypy
branch
2 times, most recently
from
fc7c3d4 to
0e0d8bc
Compare
Still contains some Any use but progress is progress nevertheless.
hairmare
force-pushed
the
chore/more-mypy
branch
from
0e0d8bc to
aebd45c
Compare
|
i'm also going to replace black+pylint with ruff in an upcoming changeset for now this is a rather minimal way to introduce quite a bit more typing hint than w/o this change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still contains some Any use but progress is progress nevertheless.