Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ensure version_detail is not None #418

Merged
merged 1 commit into from
Sep 19, 2024
Merged

ensure version_detail is not None #418

merged 1 commit into from
Sep 19, 2024

Conversation

andre-merzky
Copy link
Member

Copy link

codecov bot commented Sep 9, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 62.17%. Comparing base (37ddd89) to head (aa826a1).
Report is 2 commits behind head on devel.

Files with missing lines Patch % Lines
src/radical/utils/get_version.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            devel     #418      +/-   ##
==========================================
- Coverage   62.18%   62.17%   -0.01%     
==========================================
  Files          62       62              
  Lines        6899     6901       +2     
==========================================
+ Hits         4290     4291       +1     
- Misses       2609     2610       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@mtitov mtitov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@andre-merzky andre-merzky merged commit 1b35b9c into devel Sep 19, 2024
9 checks passed
@andre-merzky andre-merzky deleted the fix/version_detail branch September 19, 2024 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RCT version is missed in logs
2 participants