Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prefer infiniband over ethernet #393

Merged
merged 4 commits into from
Oct 25, 2023
Merged

prefer infiniband over ethernet #393

merged 4 commits into from
Oct 25, 2023

Conversation

andre-merzky
Copy link
Member

@andre-merzky andre-merzky commented Oct 24, 2023

This patch will let RU prefer (the first) infiniband interface over other (ethernet) interfaces.

@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

Merging #393 (73709d8) into devel (e5e7a6e) will decrease coverage by 0.09%.
Report is 1 commits behind head on devel.
The diff coverage is n/a.

❗ Current head 73709d8 differs from pull request most recent head 354604c. Consider uploading reports for the commit 354604c to get more accurate results

@@            Coverage Diff             @@
##            devel     #393      +/-   ##
==========================================
- Coverage   61.69%   61.60%   -0.09%     
==========================================
  Files          61       61              
  Lines        6837     6832       -5     
==========================================
- Hits         4218     4209       -9     
- Misses       2619     2623       +4     
Files Coverage Δ
src/radical/utils/host.py 81.53% <ø> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@mtitov mtitov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@andre-merzky
Copy link
Member Author

Sorry guys, Amarel tricked me (or, in other words, I was stupid). Turns out that infiniband is not accessible from the compute nodes either, had to switch to a different interface after all.

src/radical/utils/host.py Outdated Show resolved Hide resolved
@andre-merzky andre-merzky merged commit 357e032 into devel Oct 25, 2023
3 checks passed
@andre-merzky andre-merzky deleted the fix/amarel_if branch October 25, 2023 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants