Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #6081 cloudmc 2d tally controls #6225

Merged
merged 39 commits into from
Aug 18, 2023
Merged

Conversation

mkeilman
Copy link
Contributor

Notes:

  • The clipping range boxes are now two-handled sliders courtesy of jQueryUI
  • The plane position slider also uses jQueryUI for consistency
  • The controls update properly when the axis changes

The layout and labels could use some tweaking. It will also be worthwhile to put the sliders into a custom field, but that can wait to be part of #6132.

Of further note: the jQueryUI javascript file contains only the slider and its dependencies (see the download builder)

@mkeilman
Copy link
Contributor Author

Another note: because of the way the aspect ratio works, changing the clip ranges can make the plot change size or distort. We should make a new issue to more intelligently decide the plot size and aspect ratio (probably fix height or width depending on the viewable area).

@moellep
Copy link
Member

moellep commented Aug 15, 2023

I really like the Plane position widget, but I don't like the Clip options because of the distortion you mentioned and that using the mouse zoom is much more natural. We can have the Clip if you really prefer, but it should be hidden in a sub-option. When the Plane position is changed, it should preserve the current zoom settings, so you can view a section across frames.

The heatmap should show the difference between a missing tally value, and a 0.0 tally value - but this could be opened as a new issue.

@moellep
Copy link
Member

moellep commented Aug 15, 2023

The heatmap should use the same axes arrangement as the defaults on the 3D plot:
y: x by z (current is z by x)

@mkeilman
Copy link
Contributor Author

I really like the Plane position widget, but I don't like the Clip options because of the distortion you mentioned and that using the mouse zoom is much more natural. We can have the Clip if you really prefer, but it should be hidden in a sub-option. When the Plane position is changed, it should preserve the current zoom settings, so you can view a section across frames.

Clip was meant to complement zoom for cases where the area of interest is in a small area, but I'm not rabid for it. I'll remove it.

@mkeilman mkeilman marked this pull request as draft August 16, 2023 03:12
@mkeilman
Copy link
Contributor Author

To draft while I fix some things

@mkeilman
Copy link
Contributor Author

The heatmap should show the difference between a missing tally value, and a 0.0 tally value - but this could be opened as a new issue.

Seems pretty involved, as the heatmap has no concept of "don't plot anything here". For that reason ad because it would affect all apps, I agree it should be its own issue.

@mkeilman mkeilman marked this pull request as ready for review August 18, 2023 14:52
@mkeilman
Copy link
Contributor Author

Most items addressed; one extra thing I added is to rotate the default 3d view (y axis pointing in, x axis increasing leftt too right) so it matches the 2d view.

I made new issues to omit missing tally values and to preserve zoom when changing slices.

@moellep moellep enabled auto-merge (squash) August 18, 2023 15:51
@moellep moellep merged commit 3d901b9 into master Aug 18, 2023
2 checks passed
@moellep moellep deleted the 6081-cloudmc-2d-tally-controls branch August 18, 2023 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants