-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #6081 cloudmc 2d tally controls #6225
Conversation
Another note: because of the way the aspect ratio works, changing the clip ranges can make the plot change size or distort. We should make a new issue to more intelligently decide the plot size and aspect ratio (probably fix height or width depending on the viewable area). |
I really like the Plane position widget, but I don't like the Clip options because of the distortion you mentioned and that using the mouse zoom is much more natural. We can have the Clip if you really prefer, but it should be hidden in a sub-option. When the Plane position is changed, it should preserve the current zoom settings, so you can view a section across frames. The heatmap should show the difference between a missing tally value, and a 0.0 tally value - but this could be opened as a new issue. |
The heatmap should use the same axes arrangement as the defaults on the 3D plot: |
Clip was meant to complement zoom for cases where the area of interest is in a small area, but I'm not rabid for it. I'll remove it. |
To draft while I fix some things |
Seems pretty involved, as the heatmap has no concept of "don't plot anything here". For that reason ad because it would affect all apps, I agree it should be its own issue. |
Most items addressed; one extra thing I added is to rotate the default 3d view (y axis pointing in, x axis increasing leftt too right) so it matches the 2d view. I made new issues to omit missing tally values and to preserve zoom when changing slices. |
Notes:
The layout and labels could use some tweaking. It will also be worthwhile to put the sliders into a custom field, but that can wait to be part of #6132.
Of further note: the jQueryUI javascript file contains only the slider and its dependencies (see the download builder)