-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #6022 srw scale wavefront during sim #6186
Conversation
…com/radiasoft/sirepo into 6022-srw-scale-wavefront-during-sim
Latest changes:
|
This is looking really good. I think we can be a bit more aggressive on the scaling - I'll look at this and update this PR. |
- clean up preprocess files after execution
Yes, you have to set the SIREPO_JOB_MAX_MESSAGE_BYTES=2g (which matches production), and also make sure the fix for #6312 is in your source tree. |
got it, looks good |
Putting this in for review though I'm not quite sure about it. It does load the resized plots quicker. Further notes:
inspect
- copied instead of replaced because other 3d plots use the functionsOne other item: I had trouble with the example provided in the issue. The 1st watchpoint plot renders, some time after which I get a possible out of memory error. I can't test in production because the plot fails, so I don't know if it's due to an error I've introduced. I'm not sure how to find that out.