-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #4191 make websockets work in angular in parallel with http #6092
Conversation
|
@e-carlin this is ready for another review. I think it could be merged (only on in dev). The next big issues are caching frames and pub/sub for runStatus. These should be separate concerns. The former is necessary for a prod release but not the latter. One question I have is how frequently should the UI try restarts on the websocket. I think polling is fine, since it's a lightweight request. There might need to be a user alert in the UI that connection has been interrupted from more than, say, 30 seconds (server restart). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only one small comment on a comment.
All of my click around testing worked. Obviously there are counltess cases I didn't manually test so it would be good for other people to click around edge cases in their apps.
One general comment, I find myself frequently opening the developer tools network tab to view what requests are made and what the content of those requests are. With websockets and a binary protocol that now doesn't work. What about adding a pkdc to parse_message and websocket_response that allows one to dump the message (with associated uri, seq num, etc)?
|
TODO:
Depends on radiasoft/pykern#388