Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

silas enhancements #6204

Closed
10 tasks done
moellep opened this issue Aug 7, 2023 · 0 comments
Closed
10 tasks done

silas enhancements #6204

moellep opened this issue Aug 7, 2023 · 0 comments
Assignees
@moellep
Milestone
silas

Comments

@moellep
Copy link
Member

moellep commented Aug 7, 2023 •
edited
Loading

Several silas changes are required:

  • simulation error should show in the Simulation Status panel, not as a User Alert
  • Choose Crystal widget layout is incorrect on the amplifier tab
  • javascript rep-rate error is being triggered when the crystal popup editor is closed
  • rep-rate of 1.0 should be allowed
  • Sim method is already part of the crystal parameters and should be moved into the crystal panel from the simulation settings panel
  • Sim method needs to always disable if repo rate is <= 1.0
  • Sim method should be "Analytical" or "Simulated", remove Fenics text
  • When crystal is initialized in the generated code with the call to calc_n0n2(), the ABCD values should also be updated
  • Switch axes for the Radial/Axial Temp Profile plot so Longitudinal is the X axis
  • Show error message if simulation fails on Laser Pulse tab (ex. invalid pulse width)
@moellep moellep added this to the silas milestone Aug 7, 2023
@moellep moellep self-assigned this Aug 7, 2023
moellep pushed a commit that referenced this issue Aug 8, 2023
fix #6204 many silas enhancements and bug fixes
3c622fa 
- add enhancements in #6204
- added error messages to animation simulations
- hide crystal.calc_type if pump_rep_rate <= 1, always use fenics for that case
- removed thermalCrystal.crystalSimType, already present on crystal.calc_type
- autocompute ABCD matrix values and pulse.l_scale during simulations
@moellep moellep mentioned this issue Aug 8, 2023
Merged
moellep added a commit that referenced this issue Aug 8, 2023
@moellep
for #6204 fix temperature profile ranges
5159baa
moellep added a commit that referenced this issue Aug 8, 2023
@moellep
for #6204 include crystal selector on both tabs
2961268
moellep added a commit that referenced this issue Aug 8, 2023
@moellep
for #6204 remove / from report title for python source
29d2833
@moellep moellep closed this as completed in 3f856db Aug 8, 2023
This was referenced Aug 8, 2023
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@moellep moellep

Labels
None yet
Projects
None yet
Milestone
silas
Development

No branches or pull requests
1 participant
@moellep