Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

additional thermal crystal issues #6178

Closed
3 tasks done
moellep opened this issue Jul 29, 2023 · 0 comments
Closed
3 tasks done

additional thermal crystal issues #6178

moellep opened this issue Jul 29, 2023 · 0 comments
Assignees

Comments

@moellep
Copy link
Member

moellep commented Jul 29, 2023

After #6142 is released, the following issues remain:

  • Take out "BELLA" from the example name
  • Add a switch in Simulation tab to choose between analytic and simulated (fenics)
    (invoke fenics by using set_load(load_type) followed by solve_steady()/slow_solution() (depending on rep rate)
  • Restrict simtype by rep rate:
if rep rate <= 1:
    only simulated solve is allowed
elif rep rate >= 100:
    either analytical or simulated solve are allowed

gurhar1133 added a commit that referenced this issue Aug 2, 2023
gurhar1133 added a commit that referenced this issue Aug 2, 2023
gurhar1133 added a commit that referenced this issue Aug 2, 2023
gurhar1133 added a commit that referenced this issue Aug 2, 2023
gurhar1133 added a commit that referenced this issue Aug 2, 2023
gurhar1133 added a commit that referenced this issue Aug 2, 2023
gurhar1133 added a commit that referenced this issue Aug 4, 2023
gurhar1133 added a commit that referenced this issue Aug 10, 2023
* Fix #6178: WIP

* Fix #6178: analytical and simulated crystal sims

* Fix #6178: restrict simtype by rep rate WIP

* Fix #6178: restrict sim type

* Fix #6178: semi-colons

* Fix #6178: cleanup

* Fix #6178: cleanup

* Fix #6187: 3d crystal ui element

* Fix #6187: WIP

* Fix #6187: WIP

* Fix #6187: WIP

* Fix #6187: WIP

* Fix #6187: WIP

* Fix #6187: WIP

* Fix #6187: all plots

* Fix #6187: WIP

* Fix #6187: WIP

* Fix #6187: WIP

* for #6187 crystal fixes
- fixed 3D bounds cut-off values
- removed old references to plotAnimation and plot2Animation
- removed unused template.silas methods

---------

Co-authored-by: moellep <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants