Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

20230915 chx use notebook defined in metadata and r/w results from notebook defined location #6173

Closed
e-carlin opened this issue Jul 27, 2023 · 0 comments · Fixed by #6206
Closed

20230915 chx use notebook defined in metadata and r/w results from notebook defined location #6173

e-carlin opened this issue Jul 27, 2023 · 0 comments · Fixed by #6206
Assignees
@e-carlin @rorour

Comments

@e-carlin
Copy link
Member

  • chx configures which notebook to run from the metadata. We should read that in and use the configured notebook
  • We will also need to run this notebook using a conda env. We should create a script that does this for us.
  • chx has a structure to where they write output. We should know this location and read the analysis results from it. One idea is to parse the input notebook to help make sure we have the right location. But, maybe just hard code for now.

We'll need a structure that let's us do different things for the different beamlines (ex csx will still use the notebook mounted into the container)
@rorour rorour mentioned this issue Aug 7, 2023
Merged
@rorour rorour changed the title chx use notebook defined in metadata and r/w results from notebook defined location 20230915 chx use notebook defined in metadata and r/w results from notebook defined location Sep 14, 2023
rorour added a commit that referenced this issue Sep 25, 2023
@rorour @e-carlin
fix #6173: chx use notebook defined in metadata and r/w results from …
423a03e 
…notebook defined location (#6206)

* create classes for beamlines

* working ckp

* comments, format, LBYL for analysis driver

* lazily import child classes for analysis driver

* wip get notebook path for chx

* ckp

* working

* unnecessary import & var name

* add back papermill flag

* ckp

* ckp

* ckp

* ckp

* ckp

* ckp

* ckp

* ckp

* ckp

* ckp

* ckp

---------

Co-authored-by: e-carlin <[email protected]>
This was referenced Sep 26, 2023
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@e-carlin e-carlin

@rorour rorour

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@e-carlin @rorour