Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused app and server methods #6157

Closed
moellep opened this issue Jul 21, 2023 · 0 comments · Fixed by #6300
Closed

Remove unused app and server methods #6157

moellep opened this issue Jul 21, 2023 · 0 comments · Fixed by #6300
Assignees
@robnagler

Comments

@moellep
Copy link
Member

moellep commented Jul 21, 2023

We have some cruft APIs which are not being used, for example exportJupyterNotebook and exportJupyterNotebook2. These could be removed.
@moellep moellep mentioned this issue Jul 21, 2023
Merged
robnagler pushed a commit that referenced this issue Sep 2, 2023
Fix #6157 removed exportJupyterNotebook and cruft in create_archive
05292d8
robnagler pushed a commit that referenced this issue Sep 12, 2023
Fix #6268 sirepo.reply defers marshalling until send
38923f7 
- restructured sirepo.reply to avoid early json serialization
- restructured srunit to handle replies more consistently between websocket and http
- Fix #6291 restructured job_api to simplify parameters
- Fix #6293 clean up stateless/fulCompute to pass correct parameters
- Fix #6288 api_serverStatus calls asyncio.sleep
- Fix #6157 removed exportJupyterNotebook and cruft in create_archive
- Fix #6274 avoid returning json for GET on errors, include detail in HTML
- HTML is always properly rendered (formally didn't include doctype)
@robnagler robnagler mentioned this issue Sep 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@robnagler robnagler

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #6268 sirepo.reply defers marshalling until send radiasoft/sirepo
2 participants
@robnagler @moellep