Skip to content

Commit

Permalink
1.4.0
Browse files Browse the repository at this point in the history
* (R)markdown in Suggests
* vignette workaround for rstudio/rmarkdown#2163
  • Loading branch information
vnijs committed Jun 7, 2021
1 parent fbb3dd6 commit e1efff1
Show file tree
Hide file tree
Showing 3 changed files with 14 additions and 6 deletions.
5 changes: 2 additions & 3 deletions DESCRIPTION
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,14 @@ Package: radiant
Type: Package
Title: Business Analytics using R and Shiny
Version: 1.4.0
Date: 2021-5-13
Date: 2021-6-7
Authors@R: person("Vincent", "Nijs", , "[email protected]", c("aut", "cre"))
Description: A platform-independent browser-based interface for business
analytics in R, based on the shiny package. The application combines the
functionality of 'radiant.data', 'radiant.design', 'radiant.basics',
'radiant.model', and 'radiant.multivariate'.
Depends:
R (>= 3.4.0),
R (>= 3.6.0),
radiant.data (>= 1.3.0),
radiant.design (>= 1.3.0),
radiant.basics (>= 1.3.0),
Expand All @@ -26,7 +26,6 @@ Suggests:
URL: https://github.com/radiant-rstats/radiant
BugReports: https://github.com/radiant-rstats/radiant/issues
License: AGPL-3 | file LICENSE
LazyData: true
Encoding: UTF-8
RoxygenNote: 7.1.1
VignetteBuilder: knitr
12 changes: 10 additions & 2 deletions cran-comments.md
Original file line number Diff line number Diff line change
@@ -1,16 +1,24 @@
## Resubmission

This is a resubmission. In this version I have fixed an important bug (see NEWS.md for details).
This is a resubmission. In this version I have fixed an important bug (see NEWS.md for details). It seems the previous issues getting the Vignette to build on Windows are due to an issue in Rmarkdown. I tested a work around proposed by Christophe Dervieux (see https://github.com/rstudio/rmarkdown/issues/2163) and it seems to work with the win-builder test environment. A new version of Rmarkdown that addresses the issue should also be submitted to CRAN in the near future.

## Test environments

* Ubuntu 20.04 through WSL2, R 4.0.5
* Ubuntu 20.04, R 4.1.0
* win-builder (devel)

## R CMD check results

There were no ERRORs or NOTEs. However, there was one WARNING (see below). I cannot reproduce the `InvalidUrlException` mentioned however. The URL is already absolute and works as intended locally. Hopefully you can provide some guidance if needed.
There were no ERRORs or NOTEs. However, there was one WARNING (see below). I cannot reproduce the `InvalidUrlException` mentioned however. The URL is already absolute and works as intended locally.

I posted a message to the R-development mailing list and received the suggestion to ask CRAN to run the tests again.

Is it possible this is a windows build issue? Based on the below, it seems the InvalidUrlException only affects windows checks. These problems were not present when radiant version 1.3.2 was submitted, else it wouldn't have gotten on CRAN in the first place.

https://cran.r-project.org/web/checks/check_results_radiant.html

Hopefully you can provide some guidance if needed.

<https:/cdnjs.cloudflare.com/ajax/libs/font-awesome/5.15.3/css/all.min.css>

Expand Down
3 changes: 2 additions & 1 deletion vignettes/programming.Rmd
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,14 @@ author: "Vincent R. Nijs, Rady School of Management (UCSD)"
date: "`r Sys.Date()`"
output:
rmarkdown::html_vignette:
css: https://cdnjs.cloudflare.com/ajax/libs/font-awesome/5.15.3/css/all.min.css
pandoc_args: ["--css", "https://use.fontawesome.com/releases/v5.15.3/css/all.css"]
vignette: >
%\VignetteIndexEntry{Programming with Radiant}
%\VignetteEngine{knitr::rmarkdown}
\usepackage[utf8]{inputenc}
---


```{r r_setup, include = FALSE}
library(radiant)
knitr::opts_chunk$set(
Expand Down

0 comments on commit e1efff1

Please sign in to comment.