Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not make org-mode folds with matches visible #23

Closed
uggedal opened this issue Mar 6, 2020 · 7 comments
Closed

Does not make org-mode folds with matches visible #23

uggedal opened this issue Mar 6, 2020 · 7 comments

Comments

@uggedal
Copy link

uggedal commented Mar 6, 2020

isearch opens invisible org-mode sections if there are matches within them. ctrlf does not do this. It finds the matches and you can cycle between them, but they are invisible if the section is invisible.

@uggedal
Copy link
Author

uggedal commented Mar 6, 2020

@uggedal
Copy link
Author

uggedal commented Mar 6, 2020

@raxod502
Copy link
Member

Good point, that's an excellent opportunity for improvement. Thanks for the pointers.

@raxod502
Copy link
Member

Let me know if this works for your use case. It seems to work for outline-minor-mode at least, and in principle should extend to anything else supported by Isearch.

@andyleejordan
Copy link
Contributor

This unfortunately does not seem to work for hideshow. That is, if I have a block hidden by hs-hide-block, I cannot search for terms within that block. Could we re-open this? If not, I can give a repro.

@andyleejordan
Copy link
Contributor

I also seem to be able to trigger an error in the post-command-hook if blocks are hidden and I try to search through the buffer:

Error in post-command-hook (ctrlf--minibuffer-post-command-hook): (wrong-number-of-arguments (2 . 2) 1)
Error in minibuffer-exit-hook (ctrlf--minibuffer-exit-hook): (wrong-number-of-arguments (2 . 2) 1)
Quit

@raxod502
Copy link
Member

Why don't you open a new issue for this bug and I can take a look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants