Skip to content

Commit

Permalink
Merge pull request dotnet#286 from steveisok/create-unversioned-pack
Browse files Browse the repository at this point in the history
This change will flow an unversioned manifest to subscribing repos allowing them to update the pre-release label on workload manfiests. In other words, we won't have to manually update them when we bump previews or other prerelease version labels.
steveisok authored Mar 8, 2023
2 parents 4c1f185 + 74a9166 commit b1090ea
Showing 2 changed files with 9 additions and 0 deletions.
4 changes: 4 additions & 0 deletions eng/emsdk.proj
Original file line number Diff line number Diff line change
@@ -184,6 +184,10 @@
Condition="'$(AssetManifestOS)' == '' or '$(AssetManifestOS)' == 'win' or '$(ForceBuildManifestOnly)' == 'true' or '$(ArcadeBuildFromSource)' == 'true'"
Targets="Build"
Properties="PreReleaseVersionLabel=$(PreReleaseVersionLabel);PreReleaseVersionIteration=$(PreReleaseVersionIteration)" />
<MSBuild Projects="$(MSBuildThisFileDirectory)nuget\Microsoft.NET.Workload.Emscripten.Current.Manifest\Microsoft.NET.Workload.Emscripten.Current.Manifest.pkgproj"
Condition="'$(AssetManifestOS)' == '' or '$(AssetManifestOS)' == 'win' or '$(ForceBuildManifestOnly)' == 'true' or '$(ArcadeBuildFromSource)' == 'true'"
Targets="Build"
Properties="IsUnversionedManifest=true" />
<MSBuild Projects="$(MSBuildThisFileDirectory)nuget\Microsoft.NET.Workload.Emscripten.net6.Manifest\Microsoft.NET.Workload.Emscripten.net6.Manifest.pkgproj"
Condition="'$(AssetManifestOS)' == '' or '$(AssetManifestOS)' == 'win' or '$(ForceBuildManifestOnly)' == 'true' or '$(ArcadeBuildFromSource)' == 'true'"
Targets="Build"
Original file line number Diff line number Diff line change
@@ -10,6 +10,11 @@
<Description>Internal toolchain package not meant for direct consumption. Please do not reference directly.</Description>
</PropertyGroup>

<PropertyGroup Condition="'$(IsUnversionedManifest)' == 'true'">
<IsShipping>false</IsShipping>
<WorkloadVersionSuffix>_Transport</WorkloadVersionSuffix>
</PropertyGroup>

<Target Name="_PrepareForPack" BeforeTargets="GetPackageFiles" Returns="@(PackageFile)">
<!-- Override the id to include the sdk band as per the workload installer spec -->
<PropertyGroup>

0 comments on commit b1090ea

Please sign in to comment.