Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Vietnamese translation #106

Closed
wants to merge 1 commit into from
Closed

Conversation

runlevel5
Copy link
Contributor

Changes

  • Add Vietnamese locale

@dblock
Copy link
Collaborator

dblock commented Jul 2, 2020

We should probably add the supported language(s) to README and have at least one test for making sure the translation loads correctly. Want to add? Maybe something generic for all supported languages? Interested in doing that @runlevel5, I can merge otherwise.

@runlevel5
Copy link
Contributor Author

@dblock I would leave the test as a separate PR.

Feel free to merge my PR.

@dblock
Copy link
Collaborator

dblock commented Jul 6, 2020

Added with specs in 4f1737f.

@dblock dblock closed this Jul 6, 2020
@runlevel5 runlevel5 deleted the vi-locale branch August 14, 2020 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants