Add support for using dotw with Ruby w/o Rails #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dblock
force-pushed
the
remove-rails-clean
branch
2 times, most recently
from
d4f12e9 to
3d6e63f
Compare
dblock
force-pushed
the
remove-rails-clean
branch
from
3d6e63f to
c741bf3
Compare
dblock
force-pushed
the
remove-rails-clean
branch
from
734c2fb to
c741bf3
Compare
This was referenced Jul 2, 2020
Merged
radar
approved these changes
Jul 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #103.
Ruby 2.4 failure without Rails is https://stackoverflow.com/questions/41703128/error-while-trying-to-load-the-gem-devise-activesupport-duration-cant-be-coe, which has nothing to do with dotiw. There doesn't seem to be any easy fix without monkey patching things, I propose to just don't test with Ruby 2.4 w/o Rails, which I did in this PR. We still do a Rails 4 + Ruby 2.4 pass once.