Add missing executor core limit flag to app deployer #259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this looks reasonable to me, i have not tested it yet though. |
|
sorry for the late response, the change looks ok. However, travis CI has troubles https://travis-ci.org/radanalyticsio/spark-operator/jobs/596296891#L3102 Could you please try to decrease the number from 400 to 200 here https://github.com/radanalyticsio/spark-operator/blob/master/examples/app.yaml#L16 |
|
I did as you mentioned but I got no clue why tests fail. |
|
thanks, I am trying some different numbers to make travis happy, I will let you know |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add missing
spark.kubernetes.executor.limit.coresflag toKubernetesAppDeployer.java.Related Issue
Fix #255
Types of changes
🐛 Bug fix (non-breaking change which fixes an issue)