Improve ITs with UTF-8 / ISO-8859-1

racodond · Feb 27, 2017 · 316479a · 316479a
1 parent 5179711
commit 316479a
Show file tree

Hide file tree

Showing 125 changed files with 688 additions and 650 deletions.
diff --git a/...commentsExclamationMarkAndHash.properties → ...commentsExclamationMarkAndHash.properties b/...commentsExclamationMarkAndHash.properties → ...commentsExclamationMarkAndHash.properties
diff --git a/...clamationMarkMissingWhitespace.properties → ...clamationMarkMissingWhitespace.properties b/...clamationMarkMissingWhitespace.properties → ...clamationMarkMissingWhitespace.properties
diff --git a/...on/commentsExclamationMarkOnly.properties → ...on/commentsExclamationMarkOnly.properties b/...on/commentsExclamationMarkOnly.properties → ...on/commentsExclamationMarkOnly.properties
diff --git a/...commentsHashAndExclamationMark.properties → ...commentsHashAndExclamationMark.properties b/...commentsHashAndExclamationMark.properties → ...commentsHashAndExclamationMark.properties
diff --git a/.../commentsHashMissingWhitespace.properties → .../commentsHashMissingWhitespace.properties b/.../commentsHashMissingWhitespace.properties → .../commentsHashMissingWhitespace.properties
diff --git a/...nt-convention/commentsHashOnly.properties → ...nt-convention/commentsHashOnly.properties b/...nt-convention/commentsHashOnly.properties → ...nt-convention/commentsHashOnly.properties
diff --git a/...ustom/commentRegularExpression.properties → ...o8859/commentRegularExpression.properties b/...ustom/commentRegularExpression.properties → ...o8859/commentRegularExpression.properties
diff --git a/...ojects/custom/commentedOutCode.properties → ...jects/iso8859/commentedOutCode.properties b/...ojects/custom/commentedOutCode.properties → ...jects/iso8859/commentedOutCode.properties
diff --git a/...-keys/crossFileDuplicatedKeys1.properties → ...-keys/crossFileDuplicatedKeys1.properties b/...-keys/crossFileDuplicatedKeys1.properties → ...-keys/crossFileDuplicatedKeys1.properties
diff --git a/...-keys/crossFileDuplicatedKeys2.properties → ...-keys/crossFileDuplicatedKeys2.properties b/...-keys/crossFileDuplicatedKeys2.properties → ...-keys/crossFileDuplicatedKeys2.properties
diff --git a/...licated-keys-across-files/keys.properties → ...licated-keys-across-files/keys.properties b/...licated-keys-across-files/keys.properties → ...licated-keys-across-files/keys.properties
diff --git a/...icated-keys-across-files/keys2.properties → ...icated-keys-across-files/keys2.properties b/...icated-keys-across-files/keys2.properties → ...icated-keys-across-files/keys2.properties
diff --git a/...ated-keys-across-files/keys_fr.properties → ...ated-keys-across-files/keys_fr.properties b/...ated-keys-across-files/keys_fr.properties → ...ated-keys-across-files/keys_fr.properties
diff --git a/...d-keys-across-files/keys_fr_FR.properties → ...d-keys-across-files/keys_fr_FR.properties b/...d-keys-across-files/keys_fr_FR.properties → ...d-keys-across-files/keys_fr_FR.properties
diff --git a/...projects/custom/duplicatedKeys.properties → ...rojects/iso8859/duplicatedKeys.properties b/...projects/custom/duplicatedKeys.properties → ...rojects/iso8859/duplicatedKeys.properties
diff --git a/...ojects/custom/duplicatedValues.properties → ...jects/iso8859/duplicatedValues.properties b/...ojects/custom/duplicatedValues.properties → ...jects/iso8859/duplicatedValues.properties
diff --git a/...custom/duplicatedValuesCustom1.properties → ...so8859/duplicatedValuesCustom1.properties b/...custom/duplicatedValuesCustom1.properties → ...so8859/duplicatedValuesCustom1.properties
diff --git a/...custom/duplicatedValuesCustom2.properties → ...so8859/duplicatedValuesCustom2.properties b/...custom/duplicatedValuesCustom2.properties → ...so8859/duplicatedValuesCustom2.properties
diff --git a/...g/projects/custom/emptyElement.properties → .../projects/iso8859/emptyElement.properties b/...g/projects/custom/emptyElement.properties → .../projects/iso8859/emptyElement.properties
diff --git a/...jects/custom/endLineCharacters.properties → ...ects/iso8859/endLineCharacters.properties b/...jects/custom/endLineCharacters.properties → ...ects/iso8859/endLineCharacters.properties
diff --git a/...ts/custom/file-name/fileNameOK.properties → ...s/iso8859/file-name/fileNameOK.properties b/...ts/custom/file-name/fileNameOK.properties → ...s/iso8859/file-name/fileNameOK.properties
diff --git a/.../custom/file-name/file_name.ko.properties → ...iso8859/file-name/file_name.ko.properties b/.../custom/file-name/file_name.ko.properties → ...iso8859/file-name/file_name.ko.properties
diff --git a/...m/file-name/file_name.kocustom.properties → ...9/file-name/file_name.kocustom.properties b/...m/file-name/file_name.kocustom.properties → ...9/file-name/file_name.kocustom.properties
diff --git a/.../custom/file-name/file_name.ok.properties → ...iso8859/file-name/file_name.ok.properties b/.../custom/file-name/file_name.ok.properties → ...iso8859/file-name/file_name.ok.properties
diff --git a/its/ruling/projects/custom/fixme.properties → its/ruling/projects/iso8859/fixme.properties b/its/ruling/projects/custom/fixme.properties → its/ruling/projects/iso8859/fixme.properties
diff --git a/...edentials/hardCodedCredentials.properties → ...edentials/hardCodedCredentials.properties b/...edentials/hardCodedCredentials.properties → ...edentials/hardCodedCredentials.properties
diff --git a/...CodedCredentialsValuesToIgnore.properties → ...CodedCredentialsValuesToIgnore.properties b/...CodedCredentialsValuesToIgnore.properties → ...CodedCredentialsValuesToIgnore.properties
diff --git a/...custom/indentation/indentation.properties → ...so8859/indentation/indentation.properties b/...custom/indentation/indentation.properties → ...so8859/indentation/indentation.properties
diff --git a/...tion/indentationIssueFirstLine.properties → ...tion/indentationIssueFirstLine.properties b/...tion/indentationIssueFirstLine.properties → ...tion/indentationIssueFirstLine.properties
diff --git a/...9DefaultEncodingSwitchISO88591.properties → ...9DefaultEncodingSwitchISO88591.properties b/...9DefaultEncodingSwitchISO88591.properties → ...9DefaultEncodingSwitchISO88591.properties
diff --git a/...cts/custom/keyNamingConvention.properties → ...ts/iso8859/keyNamingConvention.properties b/...cts/custom/keyNamingConvention.properties → ...ts/iso8859/keyNamingConvention.properties
diff --git a/...stom/keyNamingConventionCustom.properties → ...8859/keyNamingConventionCustom.properties b/...stom/keyNamingConventionCustom.properties → ...8859/keyNamingConventionCustom.properties
diff --git a/...ts/custom/keyRegularExpression.properties → ...s/iso8859/keyRegularExpression.properties b/...ts/custom/keyRegularExpression.properties → ...s/iso8859/keyRegularExpression.properties
diff --git a/...om/keyRegularExpressionNoMatch.properties → ...59/keyRegularExpressionNoMatch.properties b/...om/keyRegularExpressionNoMatch.properties → ...59/keyRegularExpressionNoMatch.properties
diff --git a/...ing/projects/custom/lineLength.properties → ...ng/projects/iso8859/lineLength.properties b/...ing/projects/custom/lineLength.properties → ...ng/projects/iso8859/lineLength.properties
diff --git a/...ng-translations-in-default/abc.properties → ...ng-translations-in-default/abc.properties b/...ng-translations-in-default/abc.properties → ...ng-translations-in-default/abc.properties
diff --git a/...ranslations-in-default/message.properties → ...ranslations-in-default/message.properties b/...ranslations-in-default/message.properties → ...ranslations-in-default/message.properties
diff --git a/...slations-in-default/message_en.properties → ...slations-in-default/message_en.properties b/...slations-in-default/message_en.properties → ...slations-in-default/message_en.properties
diff --git a/...slations-in-default/message_es.properties → ...slations-in-default/message_es.properties b/...slations-in-default/message_es.properties → ...slations-in-default/message_es.properties
diff --git a/...slations-in-default/message_fr.properties → ...slations-in-default/message_fr.properties b/...slations-in-default/message_fr.properties → ...slations-in-default/message_fr.properties
diff --git a/...tions-in-default/message_fr_FR.properties → ...tions-in-default/message_fr_FR.properties b/...tions-in-default/message_fr_FR.properties → ...tions-in-default/message_fr_FR.properties
diff --git a/...slations-in-default/test_fr_FR.properties → ...slations-in-default/test_fr_FR.properties b/...slations-in-default/test_fr_FR.properties → ...slations-in-default/test_fr_FR.properties
diff --git a/...ustom/missing-translations/abc.properties → ...o8859/missing-translations/abc.properties b/...ustom/missing-translations/abc.properties → ...o8859/missing-translations/abc.properties
diff --git a/...m/missing-translations/message.properties → ...9/missing-translations/message.properties b/...m/missing-translations/message.properties → ...9/missing-translations/message.properties
diff --git a/...issing-translations/message_en.properties → ...issing-translations/message_en.properties b/...issing-translations/message_en.properties → ...issing-translations/message_en.properties
diff --git a/...issing-translations/message_es.properties → ...issing-translations/message_es.properties b/...issing-translations/message_es.properties → ...issing-translations/message_es.properties
diff --git a/...issing-translations/message_fr.properties → ...issing-translations/message_fr.properties b/...issing-translations/message_fr.properties → ...issing-translations/message_fr.properties
diff --git a/...ing-translations/message_fr_FR.properties → ...ing-translations/message_fr_FR.properties b/...ing-translations/message_fr_FR.properties → ...ing-translations/message_fr_FR.properties
diff --git a/...issing-translations/test_fr_FR.properties → ...issing-translations/test_fr_FR.properties b/...issing-translations/test_fr_FR.properties → ...issing-translations/test_fr_FR.properties
diff --git a/...ojects/custom/newLineEndOfFile.properties → ...jects/iso8859/newLineEndOfFile.properties b/...ojects/custom/newLineEndOfFile.properties → ...jects/iso8859/newLineEndOfFile.properties
diff --git a/...tom/no-properties/noProperties.properties → ...859/no-properties/noProperties.properties b/...tom/no-properties/noProperties.properties → ...859/no-properties/noProperties.properties
diff --git a/...m/no-properties/someProperties.properties → ...9/no-properties/someProperties.properties b/...m/no-properties/someProperties.properties → ...9/no-properties/someProperties.properties
diff --git a/...ects/custom/noNewLineEndOfFile.properties → ...cts/iso8859/noNewLineEndOfFile.properties b/...ects/custom/noNewLineEndOfFile.properties → ...cts/iso8859/noNewLineEndOfFile.properties
diff --git a/...projects/custom/noParsingError.properties → ...rojects/iso8859/noParsingError.properties b/...projects/custom/noParsingError.properties → ...rojects/iso8859/noParsingError.properties
diff --git a/...projects/custom/noTabCharacter.properties → ...rojects/iso8859/noTabCharacter.properties b/...projects/custom/noTabCharacter.properties → ...rojects/iso8859/noTabCharacter.properties
diff --git a/...g/projects/custom/parsingError.properties → .../projects/iso8859/parsingError.properties b/...g/projects/custom/parsingError.properties → .../projects/iso8859/parsingError.properties
diff --git a/...ustom/separatorConventionColon.properties → ...o8859/separatorConventionColon.properties b/...ustom/separatorConventionColon.properties → ...o8859/separatorConventionColon.properties
diff --git a/...stom/separatorConventionEquals.properties → ...8859/separatorConventionEquals.properties b/...stom/separatorConventionEquals.properties → ...8859/separatorConventionEquals.properties
diff --git a/...arscanner/deprecatedProperties.properties → ...arscanner/deprecatedProperties.properties b/...arscanner/deprecatedProperties.properties → ...arscanner/deprecatedProperties.properties
diff --git a/...g/projects/custom/tabCharacter.properties → .../projects/iso8859/tabCharacter.properties b/...g/projects/custom/tabCharacter.properties → .../projects/iso8859/tabCharacter.properties
diff --git a/its/ruling/projects/custom/todo.properties → its/ruling/projects/iso8859/todo.properties b/its/ruling/projects/custom/todo.properties → its/ruling/projects/iso8859/todo.properties
diff --git a/.../projects/custom/tooManyKeys30.properties → ...projects/iso8859/tooManyKeys30.properties b/.../projects/custom/tooManyKeys30.properties → ...projects/iso8859/tooManyKeys30.properties
diff --git a/.../projects/custom/tooManyKeys50.properties → ...projects/iso8859/tooManyKeys50.properties b/.../projects/custom/tooManyKeys50.properties → ...projects/iso8859/tooManyKeys50.properties
diff --git a/.../custom/valueRegularExpression.properties → ...iso8859/valueRegularExpression.properties b/.../custom/valueRegularExpression.properties → ...iso8859/valueRegularExpression.properties
diff --git a/.../valueRegularExpressionNoMatch.properties → .../valueRegularExpressionNoMatch.properties b/.../valueRegularExpressionNoMatch.properties → .../valueRegularExpressionNoMatch.properties
diff --git a/...uling/projects/custom/bom/utf8.properties → its/ruling/projects/utf8/bom/utf8.properties b/...uling/projects/custom/bom/utf8.properties → its/ruling/projects/utf8/bom/utf8.properties
diff --git a/...rojects/custom/bom/utf8WithBOM.properties → .../projects/utf8/bom/utf8WithBOM.properties b/...rojects/custom/bom/utf8WithBOM.properties → .../projects/utf8/bom/utf8WithBOM.properties
diff --git a/...stom/duplicatedKeysUTF8WithBOM.properties → ...utf8/duplicatedKeysUTF8WithBOM.properties b/...stom/duplicatedKeysUTF8WithBOM.properties → ...utf8/duplicatedKeysUTF8WithBOM.properties
diff --git a/...ntation/indentationUTF8WithBOM.properties → ...ntation/indentationUTF8WithBOM.properties b/...ntation/indentationUTF8WithBOM.properties → ...ntation/indentationUTF8WithBOM.properties
diff --git a/...ationUTF8WithBOMIssueFirstLine.properties → ...ationUTF8WithBOMIssueFirstLine.properties b/...ationUTF8WithBOMIssueFirstLine.properties → ...ationUTF8WithBOMIssueFirstLine.properties
diff --git a/...java9DefaultEncodingSwitchUTF8.properties → ...java9DefaultEncodingSwitchUTF8.properties b/...java9DefaultEncodingSwitchUTF8.properties → ...java9DefaultEncodingSwitchUTF8.properties
diff --git a/its/ruling/tests/src/test/expected/iso8859/jproperties-S1134.json b/its/ruling/tests/src/test/expected/iso8859/jproperties-S1134.json
@@ -0,0 +1,15 @@
+{
+'iso8859:commentedOutCode.properties':[
+72,
+73,
+76,
+77,
+],
+'iso8859:fixme.properties':[
+2,
+5,
+8,
+11,
+14,
+],
+}
diff --git a/its/ruling/tests/src/test/expected/iso8859/jproperties-S1135.json b/its/ruling/tests/src/test/expected/iso8859/jproperties-S1135.json
@@ -0,0 +1,15 @@
+{
+'iso8859:commentedOutCode.properties':[
+74,
+75,
+78,
+79,
+],
+'iso8859:todo.properties':[
+2,
+5,
+8,
+11,
+14,
+],
+}
diff --git a/its/ruling/tests/src/test/expected/iso8859/jproperties-S1578.json b/its/ruling/tests/src/test/expected/iso8859/jproperties-S1578.json
@@ -0,0 +1,11 @@
+{
+'iso8859:file-name/file_name.ko.properties':[
+0,
+],
+'iso8859:file-name/file_name.kocustom.properties':[
+0,
+],
+'iso8859:file-name/file_name.ok.properties':[
+0,
+],
+}
diff --git a/its/ruling/tests/src/test/expected/iso8859/jproperties-S2068.json b/its/ruling/tests/src/test/expected/iso8859/jproperties-S2068.json
@@ -0,0 +1,9 @@
+{
+'iso8859:hard-coded-credentials/hardCodedCredentials.properties':[
+2,
+5,
+8,
+11,
+14,
+],
+}
diff --git a/its/ruling/tests/src/test/expected/iso8859/jproperties-S2260.json b/its/ruling/tests/src/test/expected/iso8859/jproperties-S2260.json
@@ -0,0 +1,5 @@
+{
+'iso8859:parsingError.properties':[
+3,
+],
+}
diff --git a/its/ruling/tests/src/test/expected/iso8859/jproperties-comment-convention.json b/its/ruling/tests/src/test/expected/iso8859/jproperties-comment-convention.json
@@ -0,0 +1,93 @@
+{
+'iso8859:comment-convention/commentsExclamationMarkAndHash.properties':[
+1,
+4,
+6,
+9,
+],
+'iso8859:comment-convention/commentsExclamationMarkMissingWhitespace.properties':[
+1,
+2,
+2,
+3,
+3,
+],
+'iso8859:comment-convention/commentsExclamationMarkOnly.properties':[
+1,
+2,
+3,
+],
+'iso8859:comment-convention/commentsHashAndExclamationMark.properties':[
+4,
+9,
+],
+'iso8859:comment-convention/commentsHashMissingWhitespace.properties':[
+2,
+3,
+],
+'iso8859:commentRegularExpression.properties':[
+2,
+],
+'iso8859:commentedOutCode.properties':[
+3,
+5,
+11,
+11,
+13,
+13,
+15,
+17,
+19,
+21,
+23,
+25,
+27,
+29,
+31,
+33,
+35,
+37,
+39,
+41,
+43,
+45,
+57,
+58,
+60,
+61,
+62,
+68,
+69,
+70,
+72,
+73,
+73,
+74,
+75,
+75,
+76,
+77,
+77,
+78,
+79,
+79,
+],
+'iso8859:fixme.properties':[
+5,
+8,
+11,
+11,
+14,
+],
+'iso8859:indentation/indentation.properties':[
+7,
+17,
+],
+'iso8859:todo.properties':[
+5,
+8,
+11,
+11,
+14,
+],
+}
diff --git a/...ected/jproperties-commented-out-code.json → ...o8859/jproperties-commented-out-code.json b/...ected/jproperties-commented-out-code.json → ...o8859/jproperties-commented-out-code.json
@@ -1,8 +1,8 @@
 {
-'project:custom/commentRegularExpression.properties':[
+'iso8859:commentRegularExpression.properties':[
 3,
 ],
-'project:custom/commentedOutCode.properties':[
+'iso8859:commentedOutCode.properties':[
 3,
 5,
 7,

diff --git a/its/ruling/tests/src/test/expected/iso8859/jproperties-duplicated-keys-across-files.json b/its/ruling/tests/src/test/expected/iso8859/jproperties-duplicated-keys-across-files.json
@@ -0,0 +1,76 @@
+{
+'iso8859:comment-convention/commentsExclamationMarkAndHash.properties':[
+11,
+],
+'iso8859:commentRegularExpression.properties':[
+5,
+],
+'iso8859:cross-file-duplicated-keys/crossFileDuplicatedKeys1.properties':[
+2,
+3,
+4,
+],
+'iso8859:duplicated-keys-across-files/keys.properties':[
+1,
+2,
+],
+'iso8859:duplicatedKeys.properties':[
+6,
+],
+'iso8859:duplicatedValues.properties':[
+1,
+4,
+5,
+7,
+9,
+12,
+15,
+19,
+20,
+22,
+23,
+26,
+27,
+29,
+30,
+32,
+33,
+],
+'iso8859:emptyElement.properties':[
+1,
+2,
+5,
+8,
+],
+'iso8859:keyNamingConvention.properties':[
+1,
+2,
+3,
+6,
+7,
+10,
+13,
+16,
+18,
+],
+'iso8859:keyRegularExpression.properties':[
+7,
+8,
+],
+'iso8859:missing-translations-in-default/message.properties':[
+1,
+2,
+],
+'iso8859:separatorConventionColon.properties':[
+1,
+2,
+5,
+9,
+18,
+20,
+],
+'iso8859:valueRegularExpression.properties':[
+8,
+9,
+],
+}
diff --git a/its/ruling/tests/src/test/expected/iso8859/jproperties-duplicated-keys.json b/its/ruling/tests/src/test/expected/iso8859/jproperties-duplicated-keys.json
@@ -0,0 +1,38 @@
+{
+'iso8859:commentedOutCode.properties':[
+1,
+],
+'iso8859:duplicatedKeys.properties':[
+2,
+6,
+12,
+],
+'iso8859:duplicatedValuesCustom1.properties':[
+33,
+],
+'iso8859:lineLength.properties':[
+1,
+],
+'iso8859:missing-translations/message.properties':[
+3,
+],
+'iso8859:missing-translations/message_en.properties':[
+3,
+],
+'iso8859:separatorConventionColon.properties':[
+9,
+20,
+],
+'iso8859:separatorConventionEquals.properties':[
+15,
+],
+'iso8859:tooManyKeys30.properties':[
+2,
+],
+'iso8859:tooManyKeys50.properties':[
+1,
+],
+'iso8859:valueRegularExpression.properties':[
+2,
+],
+}
diff --git a/its/ruling/tests/src/test/expected/iso8859/jproperties-duplicated-values.json b/its/ruling/tests/src/test/expected/iso8859/jproperties-duplicated-values.json
@@ -0,0 +1,67 @@
+{
+'iso8859:commentedOutCode.properties':[
+1,
+],
+'iso8859:duplicatedKeys.properties':[
+2,
+],
+'iso8859:duplicatedValues.properties':[
+4,
+12,
+],
+'iso8859:duplicatedValuesCustom1.properties':[
+4,
+12,
+],
+'iso8859:duplicatedValuesCustom2.properties':[
+3,
+11,
+],
+'iso8859:emptyElement.properties':[
+1,
+],
+'iso8859:indentation/indentation.properties':[
+1,
+],
+'iso8859:indentation/indentationIssueFirstLine.properties':[
+1,
+],
+'iso8859:keyNamingConvention.properties':[
+1,
+7,
+],
+'iso8859:keyNamingConventionCustom.properties':[
+2,
+13,
+],
+'iso8859:missing-translations/abc.properties':[
+1,
+],
+'iso8859:missing-translations/message.properties':[
+1,
+],
+'iso8859:missing-translations/message_en.properties':[
+1,
+],
+'iso8859:missing-translations/message_fr.properties':[
+1,
+],
+'iso8859:missing-translations/message_fr_FR.properties':[
+1,
+],
+'iso8859:separatorConventionColon.properties':[
+1,
+],
+'iso8859:separatorConventionEquals.properties':[
+1,
+],
+'iso8859:tabCharacter.properties':[
+1,
+],
+'iso8859:tooManyKeys30.properties':[
+2,
+],
+'iso8859:tooManyKeys50.properties':[
+1,
+],
+}
diff --git a/its/ruling/tests/src/test/expected/iso8859/jproperties-empty-element.json b/its/ruling/tests/src/test/expected/iso8859/jproperties-empty-element.json
@@ -0,0 +1,26 @@
+{
+'iso8859:duplicatedValues.properties':[
+19,
+20,
+],
+'iso8859:duplicatedValuesCustom1.properties':[
+15,
+16,
+],
+'iso8859:duplicatedValuesCustom2.properties':[
+14,
+15,
+],
+'iso8859:emptyElement.properties':[
+5,
+8,
+],
+'iso8859:separatorConventionColon.properties':[
+20,
+23,
+],
+'iso8859:separatorConventionEquals.properties':[
+15,
+16,
+],
+}
diff --git a/its/ruling/tests/src/test/expected/iso8859/jproperties-empty-line-end-of-file.json b/its/ruling/tests/src/test/expected/iso8859/jproperties-empty-line-end-of-file.json
@@ -0,0 +1,8 @@
+{
+'iso8859:no-properties/noProperties.properties':[
+0,
+],
+'iso8859:noNewLineEndOfFile.properties':[
+0,
+],
+}