Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_multistack upgrade of CDK to v2 #2647

Merged
merged 2 commits into from
Nov 6, 2024

Conversation

mbordash2
Copy link
Contributor

@mbordash2 mbordash2 commented Oct 30, 2024

Summary

Upgrading the CDK multistack test suite to use the latest version of CDK, which includes an upgrade from V1 to V2.

Why This Is Needed

It is generally best practice to keep software versions up to date and given the potential vulnerability with CDK outlined in the attached issue, this fix will address that as well.

What Changed

Changed

CDK multistack test was updated to latest V2 version of CDK.
CDK bootstrap was upgraded in the test account as well.

Checklist

  • Have you followed the guidelines in our Contribution Requirements?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Does your submission pass tests?
  • Have you linted your code locally prior to submission?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?
  • Have you updated documentation, as applicable?

@mbordash2 mbordash2 added maintenance General repo or CI/CD upkeep changelog:skip Don't include this pull request in the release change log labels Oct 30, 2024
@mbordash2 mbordash2 self-assigned this Oct 30, 2024
@mbordash2 mbordash2 linked an issue Oct 30, 2024 that may be closed by this pull request
@mbordash2 mbordash2 removed the changelog:skip Don't include this pull request in the release change log label Oct 30, 2024
@ITProKyle ITProKyle added the changelog:skip Don't include this pull request in the release change log label Oct 31, 2024
tests/functional/cdk/test_multistack/.npmignore Outdated Show resolved Hide resolved
tests/functional/cdk/test_multistack/.gitignore Outdated Show resolved Hide resolved
Copy link

codecov bot commented Nov 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.20%. Comparing base (0d02431) to head (ee4ec68).
Report is 10 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2647      +/-   ##
==========================================
- Coverage   90.21%   90.20%   -0.01%     
==========================================
  Files         256      256              
  Lines       15691    15691              
==========================================
- Hits        14155    14154       -1     
- Misses       1536     1537       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ITProKyle ITProKyle merged commit 4914a7c into master Nov 6, 2024
24 checks passed
@ITProKyle ITProKyle deleted the maintenance/2641-vulnerability-in-aws-cdk-21490 branch November 6, 2024 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:skip Don't include this pull request in the release change log maintenance General repo or CI/CD upkeep
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

vulnerability in aws-cdk < 2.149.0
2 participants