Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify the base64 dependency #31

Merged
merged 1 commit into from
Jan 17, 2024
Merged

Specify the base64 dependency #31

merged 1 commit into from
Jan 17, 2024

Conversation

dentarg
Copy link
Contributor

@dentarg dentarg commented Jan 16, 2024

Addresses this warning (on Ruby 3.3):

/app/lib/rack/session/cookie.rb:11: warning: base64 was loaded from
the standard library, but is not part of the default gems since Ruby
3.4.0. Add base64 to your Gemfile or gemspec.

Close #30

Addresses this warning (on Ruby 3.3):

> /app/lib/rack/session/cookie.rb:11: warning: base64 was loaded from
> the standard library, but is not part of the default gems since Ruby
> 3.4.0. Add base64 to your Gemfile or gemspec.
Copy link
Member

@ioquatix ioquatix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with this approach.

@ioquatix ioquatix self-assigned this Jan 17, 2024
@ioquatix ioquatix merged commit 7a4e2dd into rack:main Jan 17, 2024
17 of 18 checks passed
@dentarg dentarg deleted the base64 branch January 17, 2024 13:32
ioquatix pushed a commit that referenced this pull request Jan 4, 2025
Addresses this warning (on Ruby 3.3):

> /app/lib/rack/session/cookie.rb:11: warning: base64 was loaded from
> the standard library, but is not part of the default gems since Ruby
> 3.4.0. Add base64 to your Gemfile or gemspec.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants