Non expiring Redis keys in Rails 5.2

[morgoth]

When using Rails 5.2 and built in Redis cache store https://github.com/rails/rails/blob/master/activesupport/lib/active_support/cache/redis_cache_store.rb
keys sets in Redis are not expiring.

This most likely is becuase:

• default store proxy is not picked up https://github.com/kickstarter/rack-attack/blob/master/lib/rack/attack/store_proxy.rb#L8-L13 thus it fall backs to Rails.cache
• Rails.cache responds to increment, but it ignores expires_in option, thus it results in non expiring keys

It's a serious issue as the Redis db grows quickly on the big traffic.

Workaround found so far: Rack::Attack.cache.store = Redis.current, but only with #348

It may also be resolved by closed #340 - but I didn't check it

[grzuy]

Hi @morgoth, thank you very much for reporting this issue.

I can reproduce the problem on my side also.

[grzuy]

5.3.0 released

[morgoth]

Thank you

[grzuy]

Rails.cache responds to increment, but it ignores expires_in option, thus it results in non expiring keys

For whoever is interested, Rails has changed this in master a couple of days ago. See Add :expires_in option support for RedisCacheStore increment/decrement method. I don't think it's released yet though.

[grzuy]

Rails.cache responds to increment, but it ignores expires_in option, thus it results in non expiring keys

For whoever is interested, Rails has changed this in master a couple of days ago. See Add :expires_in option support for RedisCacheStore increment/decrement method. I don't think it's released yet though.

It was released in activesupport v6.0.0.