Merge pull request #271 from grzuy/ruby_2-5

[Fixes #253] Avoid 'defined?' buggy behavior in ruby 2.5.0
rack · Mar 9, 2018 · bed046e · bed046e
2 parents 53b0561 + 6af29fb
commit bed046e
Showing 1 changed file with 8 additions and 1 deletion.
diff --git a/lib/rack/attack/store_proxy/redis_store_proxy.rb b/lib/rack/attack/store_proxy/redis_store_proxy.rb
@@ -5,7 +5,14 @@ class Attack
     module StoreProxy
       class RedisStoreProxy < SimpleDelegator
         def self.handle?(store)
-          defined?(::Redis::Store) && store.is_a?(::Redis::Store)
+          # Using const_defined? for now.
+          #
+          # Go back to use defined? once this ruby issue is
+          # fixed and released:
+          # https://bugs.ruby-lang.org/issues/14407
+          #
+          # defined?(::Redis::Store) && store.is_a?(::Redis::Store)
+          const_defined?("::Redis::Store") && store.is_a?(::Redis::Store)
         end
 
         def initialize(store)